Fix history link in Diffusion non-root browse views
ClosedPublic
Actions

Authored by epriestley on Nov 16 2015, 4:40 PM.

Details

Reviewers

chad

Maniphest Tasks

T9798: History icon url in the content browser of diffusion does not include file path

Commits

Restricted Diffusion Commit
rP5963c4c9e06d: Fix history link in Diffusion non-root browse views

Summary

Fixes T9798. That task has good repro instructions.

In sub-views, we don't link the "History" icon correctly -- we only link it to history/README instead of history/path/to/README. Add the full path.

Also canonicalize the paths in a slightly prettier and more consistenty way.

Test Plan

Viewed root and non-root browse tables, saw links show up properly.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35060.Nov 16 2015, 4:40 PM

epriestley retitled this revision from to Fix history link in Diffusion non-root browse views.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9798: History icon url in the content browser of diffusion does not include file path.

chad accepted this revision.Nov 16 2015, 4:49 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 16 2015, 4:49 PM

Closed by commit rP5963c4c9e06d: Fix history link in Diffusion non-root browse views (authored by epriestley, committed by epriestley). · Explain WhyNov 16 2015, 5:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

view/

DiffusionBrowseTableView.php

17 lines

Diff 35061

View Options

src/applications/diffusion/view/DiffusionBrowseTableView.php

Fix history link in Diffusion non-root browse viewsClosedPublicActions