Page MenuHomePhabricator
Files F15368610

D21447.id51081.diff
No OneTemporary
Actions

D21447.id51081.diff
View Options

diff --git a/src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php
--- a/src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php
@@ -38,7 +38,6 @@
protected function execute(ConduitAPIRequest $request) {
$need_messages = $request->getValue('needMessages');
- $bypass_cache = $request->getValue('bypassCache');
$viewer = $request->getUser();
$query = id(new DiffusionCommitQuery())
@@ -53,12 +52,6 @@
->executeOne();
if ($repository) {
$query->withRepository($repository);
- if ($bypass_cache) {
- id(new DiffusionRepositoryClusterEngine())
- ->setViewer($viewer)
- ->setRepository($repository)
- ->synchronizeWorkingCopyBeforeRead();
- }
}
}
@@ -111,33 +104,7 @@
'hashes' => array(),
);
- if ($bypass_cache) {
- $lowlevel_commitref = id(new DiffusionLowLevelCommitQuery())
- ->setRepository($commit->getRepository())
- ->withIdentifier($commit->getCommitIdentifier())
- ->execute();
-
- $dict['authorEpoch'] = $lowlevel_commitref->getAuthorEpoch();
- $dict['author'] = $lowlevel_commitref->getAuthor();
- $dict['authorName'] = $lowlevel_commitref->getAuthorName();
- $dict['authorEmail'] = $lowlevel_commitref->getAuthorEmail();
- $dict['committer'] = $lowlevel_commitref->getCommitter();
- $dict['committerName'] = $lowlevel_commitref->getCommitterName();
- $dict['committerEmail'] = $lowlevel_commitref->getCommitterEmail();
-
- if ($need_messages) {
- $dict['message'] = $lowlevel_commitref->getMessage();
- }
-
- foreach ($lowlevel_commitref->getHashes() as $hash) {
- $dict['hashes'][] = array(
- 'type' => $hash->getHashType(),
- 'value' => $hash->getHashValue(),
- );
- }
- }
-
- if ($need_messages && !$bypass_cache) {
+ if ($need_messages) {
$dict['message'] = $commit_data->getCommitMessage();
}

File Metadata

Mime Type
text/plain
Expires
Thu, Mar 13, 3:08 AM (1 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7354065
Default Alt Text
D21447.id51081.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility