Page MenuHomePhabricator

D8757.diff
No OneTemporary

D8757.diff

diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -597,6 +597,7 @@
$object->attachReviewerStatus($new_revision->getReviewerStatus());
$object->attachActiveDiff($new_revision->getActiveDiff());
+ $object->attachRepository($new_revision->getRepository());
foreach ($xactions as $xaction) {
switch ($xaction->getTransactionType()) {
@@ -1519,20 +1520,9 @@
DifferentialRevision $revision,
DifferentialDiff $diff) {
- $changesets = $diff->getChangesets();
-
- // TODO: This all needs to be modernized.
-
- $project = $diff->loadArcanistProject();
- if (!$project) {
- // Probably an old revision from before projects.
- return;
- }
-
- $repository = $project->loadRepository();
+ $repository = $revision->getRepository();
if (!$repository) {
- // Probably no project <-> repository link, or the repository where the
- // project lives is untracked.
+ // The repository where the code lives is untracked.
return;
}
@@ -1560,6 +1550,7 @@
}
}
+ $changesets = $diff->getChangesets();
$paths = array();
foreach ($changesets as $changeset) {
$paths[] = $path_prefix.'/'.$changeset->getFilename();

File Metadata

Mime Type
text/plain
Expires
Thu, Mar 13, 12:48 AM (2 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7224748
Default Alt Text
D8757.diff (1 KB)

Event Timeline