Page MenuHomePhabricator
Files F15367919

D11920.id28719.diff
No OneTemporary
Actions

D11920.id28719.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
*/
return array(
'names' => array(
- 'core.pkg.css' => '2e669d0e',
+ 'core.pkg.css' => 'ac11c5f8',
'core.pkg.js' => '23d653bb',
'darkconsole.pkg.js' => '8ab24e01',
'differential.pkg.css' => '4c3242f8',
@@ -128,7 +128,6 @@
'rsrc/css/phui/phui-button.css' => '21cb97f9',
'rsrc/css/phui/phui-crumbs-view.css' => '594d719e',
'rsrc/css/phui/phui-document.css' => '620b1eec',
- 'rsrc/css/phui/phui-error-view.css' => 'ffc48131',
'rsrc/css/phui/phui-feed-story.css' => 'c9f3a0b5',
'rsrc/css/phui/phui-fontkit.css' => '4394f216',
'rsrc/css/phui/phui-form-view.css' => '8b78a986',
@@ -137,6 +136,7 @@
'rsrc/css/phui/phui-icon.css' => 'd35aa857',
'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8',
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
+ 'rsrc/css/phui/phui-info-view.css' => 'b5061509',
'rsrc/css/phui/phui-list.css' => '53deb25c',
'rsrc/css/phui/phui-object-box.css' => 'd68ce5dc',
'rsrc/css/phui/phui-object-item-list-view.css' => '9db65899',
@@ -791,7 +791,7 @@
'phui-icon-view-css' => 'd35aa857',
'phui-image-mask-css' => '5a8b09c8',
'phui-info-panel-css' => '27ea50a1',
- 'phui-info-view-css' => 'ffc48131',
+ 'phui-info-view-css' => 'b5061509',
'phui-list-view-css' => '53deb25c',
'phui-object-box-css' => 'd68ce5dc',
'phui-object-item-list-view-css' => '9db65899',
diff --git a/src/applications/maniphest/controller/ManiphestTaskDetailController.php b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
--- a/src/applications/maniphest/controller/ManiphestTaskDetailController.php
+++ b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
@@ -88,38 +88,30 @@
$handles = $this->getLoadedHandles();
- $context_bar = null;
-
+ $info_view = null;
if ($parent_task) {
- $context_bar = new AphrontContextBarView();
- $context_bar->addButton(phutil_tag(
- 'a',
- array(
- 'href' => '/maniphest/task/create/?parent='.$parent_task->getID(),
- 'class' => 'green button',
- ),
- pht('Create Another Subtask')));
- $context_bar->appendChild(hsprintf(
+ $info_view = new PHUIInfoView();
+ $info_view->setSeverity(PHUIInfoView::SEVERITY_NOTICE);
+ $info_view->addButton(
+ id(new PHUIButtonView())
+ ->setHref('/maniphest/task/create/?parent='.$parent_task->getID())
+ ->setText(pht('Create Another Subtask')));
+
+ $info_view->appendChild(hsprintf(
'Created a subtask of <strong>%s</strong>',
$this->getHandle($parent_task->getPHID())->renderLink()));
} else if ($workflow == 'create') {
- $context_bar = new AphrontContextBarView();
- $context_bar->addButton(phutil_tag('label', array(), 'Create Another'));
- $context_bar->addButton(phutil_tag(
- 'a',
- array(
- 'href' => '/maniphest/task/create/?template='.$task->getID(),
- 'class' => 'green button',
- ),
- pht('Similar Task')));
- $context_bar->addButton(phutil_tag(
- 'a',
- array(
- 'href' => '/maniphest/task/create/',
- 'class' => 'green button',
- ),
- pht('Empty Task')));
- $context_bar->appendChild(pht('New task created.'));
+ $info_view = new PHUIInfoView();
+ $info_view->setSeverity(PHUIInfoView::SEVERITY_NOTICE);
+ $info_view->addButton(
+ id(new PHUIButtonView())
+ ->setHref('/maniphest/task/create/?template='.$task->getID())
+ ->setText(pht('Similar Task')));
+ $info_view->addButton(
+ id(new PHUIButtonView())
+ ->setHref('/maniphest/task/create/')
+ ->setText(pht('Empty Task')));
+ $info_view->appendChild(pht('New task created. Create another?'));
}
$engine = new PhabricatorMarkupEngine();
@@ -355,6 +347,10 @@
->setHeader($header)
->addPropertyList($properties);
+ if ($info_view) {
+ $object_box->setErrorView($info_view);
+ }
+
if ($description) {
$object_box->addPropertyList($description);
}
@@ -362,7 +358,6 @@
return $this->buildApplicationPage(
array(
$crumbs,
- $context_bar,
$object_box,
$timeline,
$comment_box,
diff --git a/webroot/rsrc/css/phui/phui-error-view.css b/webroot/rsrc/css/phui/phui-info-view.css
rename from webroot/rsrc/css/phui/phui-error-view.css
rename to webroot/rsrc/css/phui/phui-info-view.css
--- a/webroot/rsrc/css/phui/phui-error-view.css
+++ b/webroot/rsrc/css/phui/phui-info-view.css
@@ -30,6 +30,10 @@
float: right;
}
+.phui-info-view-actions .button {
+ margin-left: 4px;
+}
+
.phui-info-view-head + .phui-info-view-body {
padding-top: 4px;
}

File Metadata

Mime Type
text/plain
Expires
Wed, Mar 12, 10:06 PM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7595684
Default Alt Text
D11920.id28719.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility