Page MenuHomePhabricator
Differential D11920

Replace context bar in Maniphest with PHUIInfoView
ClosedPublic
Actions

Authored by chad on Mar 1 2015, 11:43 PM.
Tags
None
Referenced Files
F13179144: D11920.diff
Wed, May 8, 8:58 PM
Unknown Object (File)
Sat, May 4, 6:24 PM
Unknown Object (File)
Mon, Apr 29, 2:40 PM
Unknown Object (File)
Wed, Apr 24, 10:45 PM
Unknown Object (File)
Mon, Apr 22, 6:26 AM
Unknown Object (File)
Mon, Apr 15, 5:24 AM
Unknown Object (File)
Mon, Apr 15, 5:24 AM
Unknown Object (File)
Mon, Apr 15, 5:24 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP89dbe8a99556: Replace context bar in Maniphest with PHUIInfoView
Summary

Removes AphrontContext bar and uses PHUIInfoView instead. This also attaches to the ObjectBox instead for cleaner UI. Also moved phui-error-view.css which was missed.

Test Plan

Test creating a subtask or a new task, see updated info bar and action buttons.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 28719.Mar 1 2015, 11:43 PM
chad retitled this revision from to Replace context bar in Maniphest with PHUIInfoView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 1 2015, 11:43 PM
chad edited the test plan for this revision. (Show Details)Mar 1 2015, 11:45 PM
chad updated this revision to Diff 28720.Mar 1 2015, 11:46 PM
chad edited the test plan for this revision. (Show Details)
  • Actually delete AphrontContextBarView
epriestley accepted this revision.Mar 2 2015, 12:02 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2015, 12:02 AM
Closed by commit rP89dbe8a99556: Replace context bar in Maniphest with PHUIInfoView (authored by chad, committed by chad). · Explain WhyMar 2 2015, 12:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
2 lines
applications/
maniphest/
controller/
53 lines
view/
layout/
webroot/
rsrc/
css/
aphront/
phui/
phui-info-view.css
phui-error-view.css
4 lines

Diff 28721

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/view/layout/AphrontContextBarView.php

Loading...
View Options

webroot/rsrc/css/aphront/context-bar.css

Loading...
View Options

webroot/rsrc/css/phui/phui-error-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-info-view.css

Loading...
Phabricator · Built by Phacility