Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15366325
D20923.id49863.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
929 B
Referenced Files
None
Subscribers
None
D20923.id49863.diff
View Options
diff --git a/src/applications/owners/storage/PhabricatorOwnersPath.php b/src/applications/owners/storage/PhabricatorOwnersPath.php
--- a/src/applications/owners/storage/PhabricatorOwnersPath.php
+++ b/src/applications/owners/storage/PhabricatorOwnersPath.php
@@ -91,11 +91,22 @@
}
private static function getScalarKeyForRef(array $ref) {
+ // See T13464. When building refs from raw transactions, the path has
+ // not been normalized yet and doesn't have a separate "display" path.
+ // If the "display" path isn't populated, just use the actual path to
+ // build the ref key.
+
+ if (isset($ref['display'])) {
+ $display = $ref['display'];
+ } else {
+ $display = $ref['path'];
+ }
+
return sprintf(
'repository=%s path=%s display=%s excluded=%d',
$ref['repositoryPHID'],
$ref['path'],
- $ref['display'],
+ $display,
$ref['excluded']);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Mar 12, 3:04 PM (2 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7588530
Default Alt Text
D20923.id49863.diff (929 B)
Attached To
Mode
D20923: Fix an issue where editing paths in Owners packages could raise an error: undefined index "display"
Attached
Detach File
Event Timeline
Log In to Comment