D13695.diff
No OneTemporary
Actions

Size

837 B

Referenced Files

None

Subscribers

None

D13695.diff
View Options

	diff --git a/src/lint/ArcanistLintMessage.php b/src/lint/ArcanistLintMessage.php
	--- a/src/lint/ArcanistLintMessage.php
	+++ b/src/lint/ArcanistLintMessage.php
	@@ -72,6 +72,23 @@
	}

	public function setLine($line) {
	+ if ($line === null) {
	+ // This just means that we don't have any line information.
	+ } else {
	+ // For compatibility, accept digit strings since a lot of linters pass
	+ // line numbers that they have parsed from command output or XML, which
	+ // won't be properly typed.
	+ if (is_string($line) && preg_match('/^\d+\z/', $line)) {
	+ $line = (int)$line;
	+ }
	+
	+ if (!is_int($line)) {
	+ throw new Exception(
	+ pht(
	+ 'Parameter passed to setLine() must be an integer.'));
	+ }
	+ }
	+
	$this->line = $line;
	return $this;
	}