D17008.id40917.diff
No OneTemporary
Actions

Size

912 B

Referenced Files

None

Subscribers

None

D17008.id40917.diff
View Options

	diff --git a/src/applications/people/cache/PhabricatorUserPreferencesCacheType.php b/src/applications/people/cache/PhabricatorUserPreferencesCacheType.php
	--- a/src/applications/people/cache/PhabricatorUserPreferencesCacheType.php
	+++ b/src/applications/people/cache/PhabricatorUserPreferencesCacheType.php
	@@ -47,6 +47,16 @@
	foreach ($all_settings as $key => $setting) {
	$value = $preference->getSettingValue($key);

	+ try {
	+ id(clone $setting)
	+ ->setViewer($viewer)
	+ ->assertValidValue($value);
	+ } catch (Exception $ex) {
	+ // If the saved value isn't valid, don't cache it: we'll use the
	+ // default value instead.
	+ continue;
	+ }
	+
	// As an optimization, we omit the value from the cache if it is
	// exactly the same as the hardcoded default.
	$default_value = id(clone $setting)