Page MenuHomePhabricator

D19721.id47116.diff
No OneTemporary

D19721.id47116.diff

diff --git a/src/applications/differential/mail/DifferentialInlineCommentMailView.php b/src/applications/differential/mail/DifferentialInlineCommentMailView.php
--- a/src/applications/differential/mail/DifferentialInlineCommentMailView.php
+++ b/src/applications/differential/mail/DifferentialInlineCommentMailView.php
@@ -345,7 +345,13 @@
$offset_mode = 'old';
}
+ // See PHI894. Use the parse cache since we can end up with a large
+ // rendering cost otherwise when users or bots leave hundreds of inline
+ // comments on diffs with long recipient lists.
+ $cache_key = $changeset->getID();
+
$parser = id(new DifferentialChangesetParser())
+ ->setRenderCacheKey($cache_key)
->setUser($viewer)
->setChangeset($changeset)
->setOffsetMode($offset_mode)

File Metadata

Mime Type
text/plain
Expires
Tue, Mar 11, 3:05 PM (1 d, 9 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7532344
Default Alt Text
D19721.id47116.diff (812 B)

Event Timeline