Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15349731
D19721.id47116.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
812 B
Referenced Files
None
Subscribers
None
D19721.id47116.diff
View Options
diff --git a/src/applications/differential/mail/DifferentialInlineCommentMailView.php b/src/applications/differential/mail/DifferentialInlineCommentMailView.php
--- a/src/applications/differential/mail/DifferentialInlineCommentMailView.php
+++ b/src/applications/differential/mail/DifferentialInlineCommentMailView.php
@@ -345,7 +345,13 @@
$offset_mode = 'old';
}
+ // See PHI894. Use the parse cache since we can end up with a large
+ // rendering cost otherwise when users or bots leave hundreds of inline
+ // comments on diffs with long recipient lists.
+ $cache_key = $changeset->getID();
+
$parser = id(new DifferentialChangesetParser())
+ ->setRenderCacheKey($cache_key)
->setUser($viewer)
->setChangeset($changeset)
->setOffsetMode($offset_mode)
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Mar 11, 3:05 PM (1 d, 9 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7532344
Default Alt Text
D19721.id47116.diff (812 B)
Attached To
Mode
D19721: Use the changeset parse cache when rendering inline comments in mail
Attached
Detach File
Event Timeline
Log In to Comment