Details
Details
- Reviewers
amckinley - Maniphest Tasks
- T13202: Plans: 2018 Week 38-40 Bonus Content
- Commits
- rP39b85c0be039: Use the changeset parse cache when rendering inline comments in mail
- Added debugging code to stop after mail generation and show cache hits/misses.
- Left a bunch of inlines in a file.
- Ran the worker with bin/worker execute --id ....
- Before change: saw 4 comments x 2 recipients = 8 cache misses
- After change: saw 8 cache hits (cache already filled from web UI rendering)
- Removed debugging code, ran worker to completion.
- Used bin/mail show-outbound --id ... --dump-html to inspect resulting mail, saw no functional differences.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable