Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15344623
D17534.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
735 B
Referenced Files
None
Subscribers
None
D17534.diff
View Options
diff --git a/src/applications/differential/herald/DifferentialReviewersHeraldAction.php b/src/applications/differential/herald/DifferentialReviewersHeraldAction.php
--- a/src/applications/differential/herald/DifferentialReviewersHeraldAction.php
+++ b/src/applications/differential/herald/DifferentialReviewersHeraldAction.php
@@ -57,7 +57,7 @@
// If we're applying a stronger status (usually, upgrading a reviewer
// into a blocking reviewer), skip this check so we apply the change.
$old_strength = DifferentialReviewerStatus::getStatusStrength(
- $reviewers[$phid]->getStatus());
+ $reviewers[$phid]->getReviewerStatus());
if ($old_strength <= $new_strength) {
continue;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Mar 11, 5:57 AM (1 d, 20 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7503264
Default Alt Text
D17534.diff (735 B)
Attached To
Mode
D17534: Fix a bad getStatus() call which is fataling during Herald rule evaluation
Attached
Detach File
Event Timeline
Log In to Comment