Paths

Table of Contentst

Fix a bad getStatus() call which is fataling during Herald rule evaluation
ClosedPublic
Actions

Authored by epriestley on Mar 22 2017, 4:48 PM.

Tags

None

Referenced Files

	F19043057: D17534.id.diff
	Wed, Nov 26, 8:43 PM

	F19036932: D17534.diff
	Tue, Nov 25, 9:23 PM

	F18876929: D17534.id42179.diff
	Nov 6 2025, 4:59 AM

	F18836400: D17534.diff
	Oct 27 2025, 12:45 AM

	F18829286: D17534.id.diff
	Oct 24 2025, 8:58 PM

	F18825370: D17534.diff
	Oct 23 2025, 9:25 PM

	F18490375: D17534.id.diff
	Sep 3 2025, 11:27 PM

	F18473057: D17534.diff
	Sep 2 2025, 9:08 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

rPe1ee8ba428e4: Fix a bad getStatus() call which is fataling during Herald rule evaluation

Summary

Hit this while arc diff'ing something which is triggering 2+ rules which add reviewers, I think.

Test Plan

Dug this out of a production stack trace; will push and arc diff again.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 22 2017, 4:48 PM

epriestley mentioned this in D17533: When accepting revisions, allow users to accept on behalf of a subset of reviewers.Mar 22 2017, 4:49 PM

Harbormaster completed remote builds in B16086: Diff 42171.Mar 22 2017, 4:49 PM

chad accepted this revision.Mar 22 2017, 5:02 PM

This revision is now accepted and ready to land.Mar 22 2017, 5:02 PM

Closed by commit rPe1ee8ba428e4: Fix a bad getStatus() call which is fataling during Herald rule evaluation (authored by epriestley, committed by epriestley). · Explain WhyMar 22 2017, 5:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

herald/

DifferentialReviewersHeraldAction.php

2 lines

Diff 42179

View Options

src/applications/differential/herald/DifferentialReviewersHeraldAction.php

Fix a bad getStatus() call which is fataling during Herald rule evaluationClosedPublicActions