Page MenuHomePhabricator

D21462.diff
No OneTemporary

D21462.diff

diff --git a/src/applications/differential/query/DifferentialRevisionQuery.php b/src/applications/differential/query/DifferentialRevisionQuery.php
--- a/src/applications/differential/query/DifferentialRevisionQuery.php
+++ b/src/applications/differential/query/DifferentialRevisionQuery.php
@@ -778,12 +778,19 @@
*/
protected function shouldGroupQueryResultRows() {
- $join_triggers = array_merge(
- $this->pathIDs,
- $this->ccs,
- $this->reviewers);
+ if (count($this->pathIDs) > 1) {
+ return true;
+ }
+
+ if (count($this->ccs) > 1) {
+ return true;
+ }
+
+ if (count($this->reviewers) > 1) {
+ return true;
+ }
- if (count($join_triggers) > 1) {
+ if (count($this->commitHashes) > 1) {
return true;
}

File Metadata

Mime Type
text/plain
Expires
Mon, Mar 10, 9:23 AM (3 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7417058
Default Alt Text
D21462.diff (788 B)

Event Timeline