Page MenuHomePhabricator

D8958.id21255.diff
No OneTemporary

D8958.id21255.diff

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
return array(
'names' =>
array(
- 'core.pkg.css' => 'f6bd0a00',
+ 'core.pkg.css' => 'afe6e16d',
'core.pkg.js' => '417722ff',
'darkconsole.pkg.js' => 'ca8671ce',
'differential.pkg.css' => '4b8686e3',
@@ -137,9 +137,9 @@
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
'rsrc/css/phui/phui-list.css' => 'ef8035b6',
'rsrc/css/phui/phui-object-box.css' => 'ce92d8ec',
- 'rsrc/css/phui/phui-object-item-list-view.css' => '574faec3',
+ 'rsrc/css/phui/phui-object-item-list-view.css' => '24444832',
'rsrc/css/phui/phui-pinboard-view.css' => '4b346c2a',
- 'rsrc/css/phui/phui-property-list-view.css' => 'c4d44192',
+ 'rsrc/css/phui/phui-property-list-view.css' => 'af4b381f',
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
'rsrc/css/phui/phui-spacing.css' => '042804d6',
'rsrc/css/phui/phui-status.css' => '2f562399',
@@ -761,9 +761,9 @@
'phui-info-panel-css' => '27ea50a1',
'phui-list-view-css' => 'ef8035b6',
'phui-object-box-css' => 'ce92d8ec',
- 'phui-object-item-list-view-css' => '574faec3',
+ 'phui-object-item-list-view-css' => '24444832',
'phui-pinboard-view-css' => '4b346c2a',
- 'phui-property-list-view-css' => 'c4d44192',
+ 'phui-property-list-view-css' => 'af4b381f',
'phui-remarkup-preview-css' => '19ad512b',
'phui-spacing-css' => '042804d6',
'phui-status-list-view-css' => '2f562399',
diff --git a/src/applications/herald/controller/HeraldRuleListController.php b/src/applications/herald/controller/HeraldRuleListController.php
--- a/src/applications/herald/controller/HeraldRuleListController.php
+++ b/src/applications/herald/controller/HeraldRuleListController.php
@@ -47,6 +47,7 @@
->setHref($this->getApplicationURI("rule/{$id}/"));
if ($rule->isPersonalRule()) {
+ $item->addIcon('user', pht('Personal Rule'));
$item->addByline(
pht(
'Authored by %s',
diff --git a/src/applications/herald/controller/HeraldTranscriptListController.php b/src/applications/herald/controller/HeraldTranscriptListController.php
--- a/src/applications/herald/controller/HeraldTranscriptListController.php
+++ b/src/applications/herald/controller/HeraldTranscriptListController.php
@@ -64,7 +64,6 @@
$list = new PHUIObjectItemListView();
$list->setCards(true);
- $list->setFlush(true);
foreach ($transcripts as $xscript) {
$view_href = phutil_tag(
'a',
@@ -89,12 +88,7 @@
$list->addItem($item);
}
- // Render the whole page.
- $box = new PHUIObjectBoxView();
- $box->setHeaderText(pht('Herald Transcripts'));
- $box->appendChild($list);
-
- return $box;
+ return $list;
}
diff --git a/webroot/rsrc/css/phui/phui-object-item-list-view.css b/webroot/rsrc/css/phui/phui-object-item-list-view.css
--- a/webroot/rsrc/css/phui/phui-object-item-list-view.css
+++ b/webroot/rsrc/css/phui/phui-object-item-list-view.css
@@ -271,6 +271,10 @@
background: #fff;
}
+.device-phone .phui-object-item-with-1-actions .phui-object-icon-pane {
+ right: 25px;
+}
+
.device-desktop .phui-object-item-with-icons
.phui-object-item-content,
.device-desktop .phui-object-item-with-handle-icons
@@ -624,6 +628,11 @@
padding: 0;
}
+.phui-object-list-states .aphront-error-view {
+ margin: 0;
+ border: none;
+}
+
.phui-object-box .phui-object-list-states li:last-child .phui-object-item-frame {
border: none;
padding-bottom: 0;
diff --git a/webroot/rsrc/css/phui/phui-property-list-view.css b/webroot/rsrc/css/phui/phui-property-list-view.css
--- a/webroot/rsrc/css/phui/phui-property-list-view.css
+++ b/webroot/rsrc/css/phui/phui-property-list-view.css
@@ -61,7 +61,7 @@
padding-left: 12px;
text-align: left;
margin-left: 0;
- width: 100%;
+ width: auto;
}
.phui-property-list-value {
@@ -79,9 +79,10 @@
.device .phui-property-list-value,
.phui-property-list-properties.phui-property-list-stacked
.phui-property-list-value {
- padding-left: 16px;
+ padding: 0 16px;
margin-bottom: 8px;
- width: 100%;
+ width: auto;
+ word-break: break-word;
}
.phui-property-list-section-header {

File Metadata

Mime Type
text/plain
Expires
Mon, Mar 10, 5:29 AM (6 h, 24 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7403737
Default Alt Text
D8958.id21255.diff (4 KB)

Event Timeline