Page MenuHomePhabricator
Differential D8958

Fix minor design nits, Herald
ClosedPublic
Actions

Authored by chad on May 2 2014, 8:59 PM.
Tags
None
Referenced Files
F13271151: D8958.id21252.diff
Wed, May 29, 4:48 PM
F13267686: D8958.diff
Wed, May 29, 3:59 AM
F13264048: D8958.id21252.diff
Mon, May 27, 2:06 PM
F13256604: D8958.diff
Sat, May 25, 2:45 PM
F13241480: D8958.id.diff
Wed, May 22, 9:36 PM
F13232612: D8958.diff
Tue, May 21, 1:24 AM
F13229652: D8958.id21252.diff
Mon, May 20, 6:11 PM
F13224252: D8958.diff
Sun, May 19, 7:21 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
Restricted Maniphest Task
T4803: ObjectItemList icons go wild on Herald
Commits
Restricted Diffusion Commit
rP83dc10f6ac4b: Fix minor design nits, Herald
Summary
  • Personal Rules display like globals
  • Remove "boxy" look around transcripts
  • Fix Property list widths, breaks, on mobile
  • Add proper blank state for no actions
Test Plan

Tested Herald on mobile and desktop, used simulator in Chrome

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Diff 21251.May 2 2014, 8:59 PM
chad retitled this revision from to Fix minor design nits, Herald.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 2 2014, 8:59 PM
chad added a comment.May 2 2014, 8:59 PM

Screen_Shot_2014-05-02_at_1.57.36_PM.png (1×690 px, 141 KB)

Harbormaster completed remote builds in B207: Diff 21251.May 2 2014, 9:00 PM
chad updated this revision to Diff 21252.May 2 2014, 9:06 PM
  • Fix icon pane on mobile
Harbormaster completed remote builds in B208: Diff 21252.May 2 2014, 9:07 PM
epriestley accepted this revision.May 2 2014, 9:15 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 2 2014, 9:15 PM
chad closed this revision.May 2 2014, 9:26 PM
chad updated this revision to Diff 21255.

Closed by commit rP83dc10f6ac4b (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
herald/
controller/
1 line
8 lines
webroot/
rsrc/
css/
phui/
9 lines
7 lines

Diff 21255

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleListController.php

Loading...
View Options

src/applications/herald/controller/HeraldTranscriptListController.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...
Phabricator · Built by Phacility