Page MenuHomePhabricator

D18851.diff
No OneTemporary

D18851.diff

diff --git a/src/applications/differential/storage/DifferentialTransaction.php b/src/applications/differential/storage/DifferentialTransaction.php
--- a/src/applications/differential/storage/DifferentialTransaction.php
+++ b/src/applications/differential/storage/DifferentialTransaction.php
@@ -111,6 +111,12 @@
// Don't hide the initial "X added reviewers: ..." transaction during
// object creation from mail. See T12118 and PHI54.
return false;
+ case DifferentialRevisionRequestReviewTransaction::TRANSACTIONTYPE:
+ // Don't hide the initial "X requested review: ..." transaction from
+ // mail even when it occurs during creation. We need this transaction
+ // to survive so we'll generate mail when revisions immediately leave
+ // the draft state. See T13035 for discussion.
+ return false;
}
return parent::shouldHideForMail($xactions);

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 9, 1:12 PM (21 h, 25 m ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7388949
Default Alt Text
D18851.diff (925 B)

Event Timeline