Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15334902
D18851.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
925 B
Referenced Files
None
Subscribers
None
D18851.diff
View Options
diff --git a/src/applications/differential/storage/DifferentialTransaction.php b/src/applications/differential/storage/DifferentialTransaction.php
--- a/src/applications/differential/storage/DifferentialTransaction.php
+++ b/src/applications/differential/storage/DifferentialTransaction.php
@@ -111,6 +111,12 @@
// Don't hide the initial "X added reviewers: ..." transaction during
// object creation from mail. See T12118 and PHI54.
return false;
+ case DifferentialRevisionRequestReviewTransaction::TRANSACTIONTYPE:
+ // Don't hide the initial "X requested review: ..." transaction from
+ // mail even when it occurs during creation. We need this transaction
+ // to survive so we'll generate mail when revisions immediately leave
+ // the draft state. See T13035 for discussion.
+ return false;
}
return parent::shouldHideForMail($xactions);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Mar 9, 1:12 PM (21 h, 25 m ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7388949
Default Alt Text
D18851.diff (925 B)
Attached To
Mode
D18851: Always show "X requested review" in mail to stop some undraft mail from being dropped
Attached
Detach File
Event Timeline
Log In to Comment