Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15334705
D10335.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D10335.diff
View Options
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php
@@ -19,6 +19,13 @@
return 'block';
}
+ public function getApplicationTransactionRemarkupBlocks(
+ PhabricatorApplicationTransaction $xaction) {
+ return array(
+ $xaction->getNewValue(),
+ );
+ }
+
public function renderPropertyViewValue(array $handles) {
$value = $this->getFieldValue();
diff --git a/src/infrastructure/markup/PhabricatorMarkupEngine.php b/src/infrastructure/markup/PhabricatorMarkupEngine.php
--- a/src/infrastructure/markup/PhabricatorMarkupEngine.php
+++ b/src/infrastructure/markup/PhabricatorMarkupEngine.php
@@ -530,13 +530,15 @@
foreach ($content_blocks as $content_block) {
$engine->markupText($content_block);
- $ids = $engine->getTextMetadata(
+ $phids = $engine->getTextMetadata(
PhabricatorEmbedFileRemarkupRule::KEY_EMBED_FILE_PHIDS,
array());
- $files += $ids;
+ foreach ($phids as $phid) {
+ $files[$phid] = $phid;
+ }
}
- return $files;
+ return array_values($files);
}
/**
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Mar 9, 11:37 AM (2 d, 13 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7388552
Default Alt Text
D10335.diff (1 KB)
Attached To
Mode
D10335: Recognize remarkup custom fields as remarkup blocks
Attached
Detach File
Event Timeline
Log In to Comment