Page MenuHomePhabricator

Recognize remarkup custom fields as remarkup blocks
ClosedPublic

Authored by epriestley on Aug 21 2014, 11:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 10:35 PM
Unknown Object (File)
Thu, Mar 21, 8:18 PM
Unknown Object (File)
Mon, Mar 4, 2:35 PM
Unknown Object (File)
Mon, Mar 4, 1:40 PM
Unknown Object (File)
Mon, Mar 4, 6:29 AM
Unknown Object (File)
Mon, Mar 4, 6:29 AM
Unknown Object (File)
Feb 13 2024, 9:18 PM
Unknown Object (File)
Feb 10 2024, 7:47 PM
Subscribers

Details

Summary

Fixes T5916. Key insight here is that the screenshot shows a custom "Detail Solution / Notes" field, which is why this mojo doesn't work: custom remarkup fields don't emit their content for mention/file extraction.

Also fix a bug where multiple blocks with file PHIDs could be merged improperly, discarding some file PHIDs.

Test Plan

Added a custom remarkup field, added files to it, saw them attach to the task when changes were saved.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Recognize remarkup custom fields as remarkup blocks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 21 2014, 11:45 PM
epriestley updated this revision to Diff 24881.

Closed by commit rP34a90a0d2b4d (authored by @epriestley).