Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15334203
D9520.id22820.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D9520.id22820.diff
View Options
diff --git a/src/applications/maniphest/controller/ManiphestTaskDetailController.php b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
--- a/src/applications/maniphest/controller/ManiphestTaskDetailController.php
+++ b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
@@ -565,16 +565,10 @@
$column = head(array_intersect_key($columns, $in_column_phids));
if ($column) {
$column_name = pht('(%s)', $column->getDisplayName());
- // TODO: This is really hacky but there's no cleaner way to do it
- // right now, T4022 should give us better tools for this.
- $column_href = str_replace(
- 'project/view',
- 'project/board',
- $handle->getURI());
$column_link = phutil_tag(
'a',
array(
- 'href' => $column_href,
+ 'href' => $handle->getURI().'board/',
'class' => 'maniphest-board-link',
),
$column_name);
diff --git a/src/applications/project/application/PhabricatorApplicationProject.php b/src/applications/project/application/PhabricatorApplicationProject.php
--- a/src/applications/project/application/PhabricatorApplicationProject.php
+++ b/src/applications/project/application/PhabricatorApplicationProject.php
@@ -79,6 +79,7 @@
),
'/tag/' => array(
'(?P<slug>[^/]+)/' => 'PhabricatorProjectProfileController',
+ '(?P<slug>[^/]+)/board/' => 'PhabricatorProjectBoardViewController',
),
);
}
diff --git a/src/applications/project/controller/PhabricatorProjectBoardViewController.php b/src/applications/project/controller/PhabricatorProjectBoardViewController.php
--- a/src/applications/project/controller/PhabricatorProjectBoardViewController.php
+++ b/src/applications/project/controller/PhabricatorProjectBoardViewController.php
@@ -4,6 +4,7 @@
extends PhabricatorProjectBoardController {
private $id;
+ private $slug;
private $handles;
private $queryKey;
private $filter;
@@ -13,7 +14,8 @@
}
public function willProcessRequest(array $data) {
- $this->id = $data['id'];
+ $this->id = idx($data, 'id');
+ $this->slug = idx($data, 'slug');
$this->queryKey = idx($data, 'queryKey');
$this->filter = (bool)idx($data, 'filter');
}
@@ -24,12 +26,17 @@
$project = id(new PhabricatorProjectQuery())
->setViewer($viewer)
- ->needImages(true)
- ->withIDs(array($this->id))
- ->executeOne();
+ ->needImages(true);
+ if ($this->slug) {
+ $project->withSlugs(array($this->slug));
+ } else {
+ $project->withIDs(array($this->id));
+ }
+ $project = $project->executeOne();
if (!$project) {
return new Aphront404Response();
}
+
$this->setProject($project);
$columns = id(new PhabricatorProjectColumnQuery())
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Mar 9, 7:31 AM (2 w, 4 m ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7225265
Default Alt Text
D9520.id22820.diff (2 KB)
Attached To
Mode
D9520: Fix board links in TaskDetail
Attached
Detach File
Event Timeline
Log In to Comment