Paths

Table of Contentst

Differential D9520

Fix board links in TaskDetail
ClosedPublic
Actions

Authored by chad on Jun 13 2014, 8:18 PM.

Tags

None

Referenced Files

	F14345138: D9520.diff
	Thu, Dec 19, 1:05 AM

	Unknown Object (File)
	Fri, Dec 13, 12:18 AM

	Unknown Object (File)
	Tue, Dec 10, 7:30 PM

	Unknown Object (File)
	Sun, Dec 8, 3:17 PM

	Unknown Object (File)
	Sun, Dec 8, 1:21 PM

	Unknown Object (File)
	Sun, Dec 8, 7:25 AM

	Unknown Object (File)
	Fri, Dec 6, 1:16 PM

	Unknown Object (File)
	Fri, Dec 6, 6:35 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T5361: Board links in Tasks no longer link to Boards

Commits

Restricted Diffusion Commit
rPfefe5ae27c94: Fix board links in TaskDetail

Summary

Not sure if this is the correct fix, but I think it's where you intend to go?

Test Plan

Click on link in Task, get the the correct board. Click lots of links of boards and make sure everything still works.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad updated this revision to Diff 22818.Jun 13 2014, 8:18 PM

chad retitled this revision from to Fix board links in TaskDetail.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 13 2014, 8:18 PM

chad added a task: T5361: Board links in Tasks no longer link to Boards.Jun 13 2014, 8:18 PM

Harbormaster completed remote builds in B1067: Diff 22818.Jun 13 2014, 8:19 PM

This prevents a project from being called #board.

Instead, I think it's sufficient to replace tag/ with project/board/?

src/applications/maniphest/controller/ManiphestTaskDetailController.php
567–568	That is, just change this line?

Wouldn't I still need a route to translate the slug? I'm not good with routes.

Sorry, yeah, realized I am crazy. How about this?

src/applications/maniphest/controller/ManiphestTaskDetailController.php
567–568	Then this should just be `$handle->getURI().'board/'`?
src/applications/project/application/PhabricatorApplicationProject.php
82	Make this `/slug/board/` instead of `/board/slug/`.

Update per comments

Harbormaster completed remote builds in B1069: Diff 22820.Jun 13 2014, 8:55 PM

epriestley accepted this revision.Jun 13 2014, 9:01 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 13 2014, 9:01 PM

Closed by commit rPfefe5ae27c94 (authored by @chad).

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestTaskDetailController.php

8 lines

project/

application/

PhabricatorApplicationProject.php

1 line

controller/

PhabricatorProjectBoardViewController.php

15 lines

Diff 22821

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...

src/applications/project/application/PhabricatorApplicationProject.php

Loading...

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...