Page MenuHomePhabricator
Files F15333526

D21404.id.diff
No OneTemporary
Actions

D21404.id.diff
View Options

diff --git a/src/applications/diffusion/controller/DiffusionLastModifiedController.php b/src/applications/diffusion/controller/DiffusionLastModifiedController.php
--- a/src/applications/diffusion/controller/DiffusionLastModifiedController.php
+++ b/src/applications/diffusion/controller/DiffusionLastModifiedController.php
@@ -53,14 +53,6 @@
}
}
- $phids = array();
- foreach ($commits as $commit) {
- $phids[] = $commit->getCommitterDisplayPHID();
- $phids[] = $commit->getAuthorDisplayPHID();
- }
- $phids = array_filter($phids);
- $handles = $this->loadViewerHandles($phids);
-
$branch = $drequest->loadBranch();
if ($branch && $commits) {
$lint_query = id(new DiffusionLintCountQuery())
@@ -83,7 +75,6 @@
$output[$path] = $this->renderColumns(
$prequest,
- $handles,
$commit,
idx($lint, $path));
}
@@ -93,11 +84,9 @@
private function renderColumns(
DiffusionRequest $drequest,
- array $handles,
PhabricatorRepositoryCommit $commit = null,
$lint = null) {
- assert_instances_of($handles, 'PhabricatorObjectHandle');
- $viewer = $this->getRequest()->getUser();
+ $viewer = $this->getViewer();
if ($commit) {
$epoch = $commit->getEpoch();
@@ -110,13 +99,6 @@
$date = '';
}
- $author = $commit->renderAuthor($viewer, $handles);
- $committer = $commit->renderCommitter($viewer, $handles);
-
- if ($author != $committer) {
- $author = hsprintf('%s/%s', $author, $committer);
- }
-
$data = $commit->getCommitData();
$details = DiffusionView::linkDetail(
$drequest->getRepository(),
@@ -124,11 +106,9 @@
$data->getSummary());
$details = AphrontTableView::renderSingleDisplayLine($details);
-
$return = array(
'commit' => $modified,
'date' => $date,
- 'author' => $author,
'details' => $details,
);
diff --git a/src/applications/diffusion/view/DiffusionBrowseTableView.php b/src/applications/diffusion/view/DiffusionBrowseTableView.php
--- a/src/applications/diffusion/view/DiffusionBrowseTableView.php
+++ b/src/applications/diffusion/view/DiffusionBrowseTableView.php
@@ -76,7 +76,6 @@
$dict = array(
'lint' => celerity_generate_unique_node_id(),
'date' => celerity_generate_unique_node_id(),
- 'author' => celerity_generate_unique_node_id(),
'details' => celerity_generate_unique_node_id(),
);

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 9, 2:50 AM (1 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7332838
Default Alt Text
D21404.id.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility