Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15333446
D17652.id42454.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D17652.id42454.diff
View Options
diff --git a/src/applications/differential/xaction/DifferentialRevisionActionTransaction.php b/src/applications/differential/xaction/DifferentialRevisionActionTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionActionTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionActionTransaction.php
@@ -124,10 +124,14 @@
list($options, $value) = $this->getActionOptions($viewer, $revision);
// Show the options if the user can select on behalf of two or more
- // reviewers, or can force-accept on behalf of one or more reviewers.
+ // reviewers, or can force-accept on behalf of one or more reviewers,
+ // or can accept on behalf of a reviewer other than themselves (see
+ // T12533).
$can_multi = (count($options) > 1);
$can_force = (count($value) < count($options));
- if ($can_multi || $can_force) {
+ $not_self = (head_key($options) != $viewer->getPHID());
+
+ if ($can_multi || $can_force || $not_self) {
$field->setOptions($options);
$field->setValue($value);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Mar 9, 2:22 AM (3 d, 14 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7385810
Default Alt Text
D17652.id42454.diff (1 KB)
Attached To
Mode
D17652: When reviewing, always show "Accept" checkboxes for packages/projects, even if there's only one checkbox
Attached
Detach File
Event Timeline
Log In to Comment