Page MenuHomePhabricator
Files F15333357

D21475.id51117.diff
No OneTemporary
Actions

D21475.id51117.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -13,7 +13,7 @@
'core.pkg.js' => 'adc34883',
'dark-console.pkg.js' => '187792c2',
'differential.pkg.css' => '5c459f92',
- 'differential.pkg.js' => '218fda21',
+ 'differential.pkg.js' => '5080baf4',
'diffusion.pkg.css' => '42c75c37',
'diffusion.pkg.js' => '8ee48a4b',
'maniphest.pkg.css' => '35995d6d',
@@ -383,7 +383,7 @@
'rsrc/js/application/dashboard/behavior-dashboard-move-panels.js' => 'a2ab19be',
'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '1e413dc9',
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => '0116d3e8',
- 'rsrc/js/application/diff/DiffChangeset.js' => '39dcf2c3',
+ 'rsrc/js/application/diff/DiffChangeset.js' => '3b6e1fde',
'rsrc/js/application/diff/DiffChangesetList.js' => 'cc2c5de5',
'rsrc/js/application/diff/DiffInline.js' => '511a1315',
'rsrc/js/application/diff/DiffPathView.js' => '8207abf9',
@@ -784,7 +784,7 @@
'phabricator-darklog' => '3b869402',
'phabricator-darkmessage' => '26cd4b73',
'phabricator-dashboard-css' => '5a205b9d',
- 'phabricator-diff-changeset' => '39dcf2c3',
+ 'phabricator-diff-changeset' => '3b6e1fde',
'phabricator-diff-changeset-list' => 'cc2c5de5',
'phabricator-diff-inline' => '511a1315',
'phabricator-diff-path-view' => '8207abf9',
@@ -1229,7 +1229,14 @@
'trigger-rule',
'trigger-rule-type',
),
- '39dcf2c3' => array(
+ '3ae89b20' => array(
+ 'phui-workcard-view-css',
+ ),
+ '3b4899b0' => array(
+ 'javelin-behavior',
+ 'phabricator-prefab',
+ ),
+ '3b6e1fde' => array(
'javelin-dom',
'javelin-util',
'javelin-stratcom',
@@ -1243,13 +1250,6 @@
'phuix-button-view',
'javelin-external-editor-link-engine',
),
- '3ae89b20' => array(
- 'phui-workcard-view-css',
- ),
- '3b4899b0' => array(
- 'javelin-behavior',
- 'phabricator-prefab',
- ),
'3be6ef4f' => array(
'javelin-behavior',
'javelin-dom',
diff --git a/webroot/rsrc/js/application/diff/DiffChangeset.js b/webroot/rsrc/js/application/diff/DiffChangeset.js
--- a/webroot/rsrc/js/application/diff/DiffChangeset.js
+++ b/webroot/rsrc/js/application/diff/DiffChangeset.js
@@ -723,16 +723,19 @@
var data = JX.Stratcom.getData(node);
if (!data.inline) {
- var inline = new JX.DiffInline()
- .setChangeset(this)
- .bindToRow(node);
-
- this._inlines.push(inline);
+ var inline = this._newInlineForRow(node);
+ this.getInlines().push(inline);
}
return data.inline;
},
+ _newInlineForRow: function(node) {
+ return new JX.DiffInline()
+ .setChangeset(this)
+ .bindToRow(node);
+ },
+
newInlineForRange: function(origin, target, options) {
var list = this.getChangesetList();
@@ -770,7 +773,7 @@
.setChangeset(this)
.bindToRange(data);
- this._inlines.push(inline);
+ this.getInlines().push(inline);
inline.create();
@@ -855,9 +858,7 @@
continue;
}
- // As a side effect, this builds any missing inline objects and adds
- // them to this Changeset's list of inlines.
- this.getInlineForRow(row);
+ this._inlines.push(this._newInlineForRow(row));
}
},

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 9, 2:03 AM (1 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7382378
Default Alt Text
D21475.id51117.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility