Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15331918
D21218.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
906 B
Referenced Files
None
Subscribers
None
D21218.diff
View Options
diff --git a/src/applications/differential/query/DifferentialTransactionQuery.php b/src/applications/differential/query/DifferentialTransactionQuery.php
--- a/src/applications/differential/query/DifferentialTransactionQuery.php
+++ b/src/applications/differential/query/DifferentialTransactionQuery.php
@@ -33,6 +33,17 @@
foreach ($inlines as $key => $inline) {
if ($inline->isVoidComment($viewer)) {
unset($inlines[$key]);
+ continue;
+ }
+
+ // For other inlines: if they have a nonempty draft state, set their
+ // content to the draft state content. We want to submit the comment
+ // as it is currently shown to the user, not as it was stored the last
+ // time they clicked "Save".
+
+ $draft_content = $inline->getContentForEdit($viewer);
+ if (strlen($draft_content)) {
+ $inline->setContent($draft_content);
}
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Mar 8, 3:16 PM (2 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7382938
Default Alt Text
D21218.diff (906 B)
Attached To
Mode
D21218: When a user submits "isEditing" inlines and chooses to publish them, publish their current draft state as-shown
Attached
Detach File
Event Timeline
Log In to Comment