Page MenuHomePhabricator
Files F15331786

D21296.diff
No OneTemporary
Actions

D21296.diff
View Options

diff --git a/src/workflow/ArcanistDiffWorkflow.php b/src/workflow/ArcanistDiffWorkflow.php
--- a/src/workflow/ArcanistDiffWorkflow.php
+++ b/src/workflow/ArcanistDiffWorkflow.php
@@ -78,10 +78,6 @@
return true;
}
- if ($this->getArgument('use-commit-message')) {
- return true;
- }
-
return false;
}
@@ -106,19 +102,6 @@
'When creating a revision, read revision information '.
'from this file.'),
),
- 'use-commit-message' => array(
- 'supports' => array(
- 'git',
- // TODO: Support mercurial.
- ),
- 'short' => 'C',
- 'param' => 'commit',
- 'help' => pht('Read revision information from a specific commit.'),
- 'conflicts' => array(
- 'only' => null,
- 'update' => null,
- ),
- ),
'edit' => array(
'supports' => array(
'git',
@@ -332,7 +315,6 @@
'git',
),
'conflicts' => array(
- 'use-commit-message' => true,
'update' => true,
'only' => true,
'raw' => true,
@@ -823,10 +805,6 @@
return false;
}
- if ($this->getArgument('use-commit-message')) {
- return false;
- }
-
if ($this->isRawDiffSource()) {
return true;
}
@@ -1482,13 +1460,8 @@
$is_create = $this->getArgument('create');
$is_update = $this->getArgument('update');
$is_raw = $this->isRawDiffSource();
- $is_message = $this->getArgument('use-commit-message');
$is_verbatim = $this->getArgument('verbatim');
- if ($is_message) {
- return $this->getCommitMessageFromCommit($is_message);
- }
-
if ($is_verbatim) {
return $this->getCommitMessageFromUser();
}
@@ -1543,18 +1516,6 @@
}
- /**
- * @task message
- */
- private function getCommitMessageFromCommit($commit) {
- $text = $this->getRepositoryAPI()->getCommitMessage($commit);
- $message = ArcanistDifferentialCommitMessage::newFromRawCorpus($text);
- $message->pullDataFromConduit($this->getConduit());
- $this->validateCommitMessage($message);
- return $message;
- }
-
-
/**
* @task message
*/

File Metadata

Mime Type
text/plain
Expires
Sat, Mar 8, 1:42 PM (4 d, 8 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7340730
Default Alt Text
D21296.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility