D21491.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D21491.diff
View Options

	diff --git a/src/applications/differential/engine/DifferentialRevisionTimelineEngine.php b/src/applications/differential/engine/DifferentialRevisionTimelineEngine.php
	--- a/src/applications/differential/engine/DifferentialRevisionTimelineEngine.php
	+++ b/src/applications/differential/engine/DifferentialRevisionTimelineEngine.php
	@@ -57,15 +57,17 @@
	// side effect, which means it will ultimately adjust the transaction
	// comments and affect timeline rendering.

	- $old = array_select_keys($changesets, $old_ids);
	- $new = array_select_keys($changesets, $new_ids);
	- id(new PhabricatorInlineCommentAdjustmentEngine())
	- ->setViewer($viewer)
	- ->setRevision($revision)
	- ->setOldChangesets($old)
	- ->setNewChangesets($new)
	- ->setInlines($inlines)
	- ->execute();
	+ if (!empty($new)) {
	+ $old = array_select_keys($changesets, $old_ids);
	+ $new = array_select_keys($changesets, $new_ids);
	+ id(new PhabricatorInlineCommentAdjustmentEngine())
	+ ->setViewer($viewer)
	+ ->setRevision($revision)
	+ ->setOldChangesets($old)
	+ ->setNewChangesets($new)
	+ ->setInlines($inlines)
	+ ->execute();
	+ }

	return id(new DifferentialTransactionView())
	->setViewData($view_data)