Page MenuHomePhabricator
Files F15294836

D12751.diff
No OneTemporary
Actions

D12751.diff
View Options

diff --git a/src/unit/parser/ArcanistPhpunitTestResultParser.php b/src/unit/parser/ArcanistPhpunitTestResultParser.php
--- a/src/unit/parser/ArcanistPhpunitTestResultParser.php
+++ b/src/unit/parser/ArcanistPhpunitTestResultParser.php
@@ -35,7 +35,7 @@
$results = array();
foreach ($report as $event) {
- switch ($event->event) {
+ switch (idx($event, 'event')) {
case 'test':
break;
case 'testStart':
@@ -48,34 +48,42 @@
$status = ArcanistUnitTestResult::RESULT_PASS;
$user_data = '';
- if ('fail' == $event->status) {
+ if ('fail' == idx($event, 'status')) {
$status = ArcanistUnitTestResult::RESULT_FAIL;
- $user_data .= $event->message."\n";
- foreach ($event->trace as $trace) {
- $user_data .= sprintf("\n%s:%s", $trace->file, $trace->line);
+ $user_data .= idx($event, 'message')."\n";
+ foreach (idx($event, 'trace') as $trace) {
+ $user_data .= sprintf(
+ "\n%s:%s",
+ idx($trace, 'file'),
+ idx($trace, 'line'));
}
- } else if ('error' == $event->status) {
- if (strpos($event->message, 'Skipped Test') !== false) {
+ } else if ('error' == idx($event, 'status')) {
+ if (strpos(idx($event, 'message'), 'Skipped Test') !== false) {
$status = ArcanistUnitTestResult::RESULT_SKIP;
- $user_data .= $event->message;
- } else if (strpos($event->message, 'Incomplete Test') !== false) {
+ $user_data .= idx($event, 'message');
+ } else if (strpos(
+ idx($event, 'message'),
+ 'Incomplete Test') !== false) {
$status = ArcanistUnitTestResult::RESULT_SKIP;
- $user_data .= $event->message;
+ $user_data .= idx($event, 'message');
} else {
$status = ArcanistUnitTestResult::RESULT_BROKEN;
- $user_data .= $event->message;
- foreach ($event->trace as $trace) {
- $user_data .= sprintf("\n%s:%s", $trace->file, $trace->line);
+ $user_data .= idx($event, 'message');
+ foreach (idx($event, 'trace') as $trace) {
+ $user_data .= sprintf(
+ "\n%s:%s",
+ idx($trace, 'file'),
+ idx($trace, 'line'));
}
}
}
- $name = preg_replace('/ \(.*\)/s', '', $event->test);
+ $name = preg_replace('/ \(.*\)/s', '', idx($event, 'test'));
$result = new ArcanistUnitTestResult();
$result->setName($name);
$result->setResult($status);
- $result->setDuration($event->time);
+ $result->setDuration(idx($event, 'time'));
$result->setCoverage($coverage);
$result->setUserData($user_data);
@@ -85,7 +93,7 @@
if (!$last_test_finished) {
$results[] = id(new ArcanistUnitTestResult())
- ->setName($event->test) // use last event
+ ->setName(idx($event, 'test')) // use last event
->setUserData($this->stderr)
->setResult(ArcanistUnitTestResult::RESULT_BROKEN);
}

File Metadata

Mime Type
text/plain
Expires
Thu, Mar 6, 11:02 AM (2 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7243418
Default Alt Text
D12751.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility