Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15283826
D21459.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D21459.id.diff
View Options
diff --git a/src/infrastructure/daemon/workers/PhabricatorWorker.php b/src/infrastructure/daemon/workers/PhabricatorWorker.php
--- a/src/infrastructure/daemon/workers/PhabricatorWorker.php
+++ b/src/infrastructure/daemon/workers/PhabricatorWorker.php
@@ -162,6 +162,19 @@
try {
$worker->executeTask();
$worker->flushTaskQueue();
+
+ $task_result = PhabricatorWorkerArchiveTask::RESULT_SUCCESS;
+ break;
+ } catch (PhabricatorWorkerPermanentFailureException $ex) {
+ $proxy = new PhutilProxyException(
+ pht(
+ 'In-process task ("%s") failed permanently.',
+ $task_class),
+ $ex);
+
+ phlog($proxy);
+
+ $task_result = PhabricatorWorkerArchiveTask::RESULT_FAILURE;
break;
} catch (PhabricatorWorkerYieldException $ex) {
phlog(
@@ -177,9 +190,7 @@
// object with a valid ID.
$task->openTransaction();
$task->save();
- $archived = $task->archiveTask(
- PhabricatorWorkerArchiveTask::RESULT_SUCCESS,
- 0);
+ $archived = $task->archiveTask($task_result, 0);
$task->saveTransaction();
return $archived;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Mar 5, 8:39 AM (5 d, 12 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7224269
Default Alt Text
D21459.id.diff (1 KB)
Attached To
Mode
D21459: When an in-process worker subtask fails permanently, don't fatal the whole process
Attached
Detach File
Event Timeline
Log In to Comment