Page MenuHomePhabricator
Files F15283525

D21211.diff
No OneTemporary
Actions

D21211.diff
View Options

diff --git a/src/applications/audit/storage/PhabricatorAuditTransactionComment.php b/src/applications/audit/storage/PhabricatorAuditTransactionComment.php
--- a/src/applications/audit/storage/PhabricatorAuditTransactionComment.php
+++ b/src/applications/audit/storage/PhabricatorAuditTransactionComment.php
@@ -81,4 +81,8 @@
return $this;
}
+ public function isEmptyInlineComment() {
+ return !strlen($this->getContent());
+ }
+
}
diff --git a/src/applications/differential/storage/DifferentialTransactionComment.php b/src/applications/differential/storage/DifferentialTransactionComment.php
--- a/src/applications/differential/storage/DifferentialTransactionComment.php
+++ b/src/applications/differential/storage/DifferentialTransactionComment.php
@@ -127,4 +127,8 @@
return $this;
}
+ public function isEmptyInlineComment() {
+ return !strlen($this->getContent());
+ }
+
}
diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -5033,7 +5033,12 @@
$xactions = array();
- foreach ($inlines as $inline) {
+ foreach ($inlines as $key => $inline) {
+ if ($inline->isEmptyInlineComment()) {
+ unset($inlines[$key]);
+ continue;
+ }
+
$xactions[] = $object->getApplicationTransactionTemplate()
->setTransactionType($transaction_type)
->attachComment($inline);
@@ -5079,6 +5084,13 @@
$inlines = array_mergev($inlines);
+ foreach ($inlines as $key => $inline) {
+ if ($inline->isEmptyInlineComment()) {
+ unset($inlines[$key]);
+ continue;
+ }
+ }
+
if (!$inlines) {
return null;
}

File Metadata

Mime Type
text/plain
Expires
Wed, Mar 5, 7:43 AM (2 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7223990
Default Alt Text
D21211.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility