Page MenuHomePhabricator

Don't publish "empty" inline comments
ClosedPublic

Authored by epriestley on Mon, May 4, 4:26 PM.

Details

Summary

Ref T13513. Currently, if you start an inline and then submit overall comments, we publish an empty inline. This is literally faithful to what you did, but almost certainly not the intent.

Instead, simply ignore empty inlines at publishing time (and ignore "done" state changes for those comments).

We could delete them outright, but if we do, they'll break if you have another window open with the empty inline (since the stored comment won't exist anymore). At least for now, leave them in place.

Test Plan

Created empty inlines, submitted comments, no longer saw them publish.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, May 4, 4:26 PM
epriestley requested review of this revision.Mon, May 4, 4:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, May 4, 8:14 PM
This revision was automatically updated to reflect the committed changes.