D15233.id36761.diff
No OneTemporary
Actions

Size

878 B

Referenced Files

None

Subscribers

None

D15233.id36761.diff
View Options

	diff --git a/src/land/ArcanistGitLandEngine.php b/src/land/ArcanistGitLandEngine.php
	--- a/src/land/ArcanistGitLandEngine.php
	+++ b/src/land/ArcanistGitLandEngine.php
	@@ -128,10 +128,22 @@
	pht('FETCH'),
	pht('Fetching %s...', $ref));

	- $api->execxLocal(
	+ // NOTE: Although this output isn't hugely useful, we need to passthru
	+ // instead of using a subprocess here because `git fetch` may prompt the
	+ // user to enter a password if they're fetching over HTTP with basic
	+ // authentication. See T10314.
	+
	+ $err = $api->execPassthru(
	'fetch -- %s %s',
	$this->getTargetRemote(),
	$this->getTargetOnto());
	+
	+ if ($err) {
	+ throw new ArcanistUsageException(
	+ pht(
	+ 'Fetch failed! Fix the error and run "%s" again.',
	+ 'arc land'));
	+ }
	}

	private function updateWorkingCopy() {