Page MenuHomePhabricator

Use passthru to run `git fetch` in `arc land` so password prompts work
ClosedPublic

Authored by epriestley on Feb 10 2016, 2:24 PM.
Tags
None
Referenced Files
F15433129: D15233.diff
Mon, Mar 24, 9:37 PM
F15421967: D15233.id36761.diff
Sat, Mar 22, 4:04 AM
F15394567: D15233.id36766.diff
Sat, Mar 15, 11:55 PM
F15394565: D15233.id36761.diff
Sat, Mar 15, 11:55 PM
F15374729: D15233.id36766.diff
Wed, Mar 12, 8:16 PM
F15374728: D15233.id36761.diff
Wed, Mar 12, 8:16 PM
F15335891: D15233.id36766.diff
Mar 8 2025, 5:39 PM
F15335890: D15233.id36761.diff
Mar 8 2025, 5:39 PM
Subscribers

Details

Summary

Fixes T10314. In arc land, we currently run git fetch as a subprocess.

However, this can prevent password prompts (when fetching over HTTP with basic authentication) from working properly.

Instead, use passthru to redirect stdin/stdout to the subprocess so the user can type their password.

This adds a little extra clutter to the arc land output but I think that's OK.

Test Plan

See T10314, @maxie confirmed this fixes the issue.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use passthru to run `git fetch` in `arc land` so password prompts work.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a subscriber: maxie.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 10 2016, 3:03 PM
This revision was automatically updated to reflect the committed changes.