Use passthru to run `git fetch` in `arc land` so password prompts work
ClosedPublic
Actions

Authored by epriestley on Feb 10 2016, 2:24 PM.

Details

Reviewers

chad

Maniphest Tasks

T10314: arc land freezes on up-to-date version

Commits

rARCd6b1531b94b2: Use passthru to run `git fetch` in `arc land` so password prompts work

Summary

Fixes T10314. In arc land, we currently run git fetch as a subprocess.

However, this can prevent password prompts (when fetching over HTTP with basic authentication) from working properly.

Instead, use passthru to redirect stdin/stdout to the subprocess so the user can type their password.

This adds a little extra clutter to the arc land output but I think that's OK.

Test Plan

See T10314, @maxie confirmed this fixes the issue.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36761.Feb 10 2016, 2:24 PM

epriestley retitled this revision from to Use passthru to run `git fetch` in `arc land` so password prompts work.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10314: arc land freezes on up-to-date version.

epriestley added a subscriber: maxie.

chad accepted this revision.Feb 10 2016, 3:03 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 10 2016, 3:03 PM

Closed by commit rARCd6b1531b94b2: Use passthru to run `git fetch` in `arc land` so password prompts work (authored by epriestley, committed by epriestley). · Explain WhyFeb 10 2016, 8:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

land/

ArcanistGitLandEngine.php

14 lines

Diff 36766

View Options

src/land/ArcanistGitLandEngine.php

Use passthru to run `git fetch` in `arc land` so password prompts workClosedPublicActions