D14625.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D14625.diff
View Options

	diff --git a/src/lint/linter/xhpast/rules/ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php b/src/lint/linter/xhpast/rules/ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php
	--- a/src/lint/linter/xhpast/rules/ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php
	+++ b/src/lint/linter/xhpast/rules/ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php
	@@ -14,21 +14,25 @@
	}

	public function process(XHPASTNode $root) {
	- static $cast_functions = array(
	- 'boolval' => 'bool',
	- 'doubleval' => 'double',
	- 'floatval' => 'double',
	- 'intval' => 'int',
	- 'strval' => 'string',
	- );
	+ static $cast_functions;
	+
	+ if ($cast_functions === null) {
	+ $cast_functions = new CaseInsensitiveArray(array(
	+ 'boolval' => 'bool',
	+ 'doubleval' => 'double',
	+ 'floatval' => 'double',
	+ 'intval' => 'int',
	+ 'strval' => 'string',
	+ ));
	+ }

	- $casts = $this->getFunctionCalls($root, array_keys($cast_functions));
	+ $casts = $this->getFunctionCalls($root, $cast_functions->getKeys());

	foreach ($casts as $cast) {
	$function_name = $cast
	->getChildOfType(0, 'n_SYMBOL_NAME')
	->getConcreteString();
	- $cast_name = $cast_functions[strtolower($function_name)];
	+ $cast_name = $cast_functions[$function_name];

	$parameters = $cast->getChildOfType(1, 'n_CALL_PARAMETER_LIST');
	$replacement = null;