Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15190623
D16429.id39508.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
28 KB
Referenced Files
None
Subscribers
None
D16429.id39508.diff
View Options
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -2140,6 +2140,7 @@
'PhabricatorConduitTokensSettingsPanel' => 'applications/conduit/settings/PhabricatorConduitTokensSettingsPanel.php',
'PhabricatorConfigAllController' => 'applications/config/controller/PhabricatorConfigAllController.php',
'PhabricatorConfigApplication' => 'applications/config/application/PhabricatorConfigApplication.php',
+ 'PhabricatorConfigApplicationController' => 'applications/config/controller/PhabricatorConfigApplicationController.php',
'PhabricatorConfigCacheController' => 'applications/config/controller/PhabricatorConfigCacheController.php',
'PhabricatorConfigClusterDatabasesController' => 'applications/config/controller/PhabricatorConfigClusterDatabasesController.php',
'PhabricatorConfigClusterNotificationsController' => 'applications/config/controller/PhabricatorConfigClusterNotificationsController.php',
@@ -2201,7 +2202,6 @@
'PhabricatorConfigTransaction' => 'applications/config/storage/PhabricatorConfigTransaction.php',
'PhabricatorConfigTransactionQuery' => 'applications/config/query/PhabricatorConfigTransactionQuery.php',
'PhabricatorConfigValidationException' => 'applications/config/exception/PhabricatorConfigValidationException.php',
- 'PhabricatorConfigVersionsModule' => 'applications/config/module/PhabricatorConfigVersionsModule.php',
'PhabricatorConfigWelcomeController' => 'applications/config/controller/PhabricatorConfigWelcomeController.php',
'PhabricatorConpherenceApplication' => 'applications/conpherence/application/PhabricatorConpherenceApplication.php',
'PhabricatorConpherenceColumnVisibleSetting' => 'applications/settings/setting/PhabricatorConpherenceColumnVisibleSetting.php',
@@ -6877,6 +6877,7 @@
'PhabricatorConduitTokensSettingsPanel' => 'PhabricatorSettingsPanel',
'PhabricatorConfigAllController' => 'PhabricatorConfigController',
'PhabricatorConfigApplication' => 'PhabricatorApplication',
+ 'PhabricatorConfigApplicationController' => 'PhabricatorConfigController',
'PhabricatorConfigCacheController' => 'PhabricatorConfigController',
'PhabricatorConfigClusterDatabasesController' => 'PhabricatorConfigController',
'PhabricatorConfigClusterNotificationsController' => 'PhabricatorConfigController',
@@ -6945,7 +6946,6 @@
'PhabricatorConfigTransaction' => 'PhabricatorApplicationTransaction',
'PhabricatorConfigTransactionQuery' => 'PhabricatorApplicationTransactionQuery',
'PhabricatorConfigValidationException' => 'Exception',
- 'PhabricatorConfigVersionsModule' => 'PhabricatorConfigModule',
'PhabricatorConfigWelcomeController' => 'PhabricatorConfigController',
'PhabricatorConpherenceApplication' => 'PhabricatorApplication',
'PhabricatorConpherenceColumnVisibleSetting' => 'PhabricatorInternalSetting',
diff --git a/src/applications/auth/engine/PhabricatorAuthSessionEngineExtensionModule.php b/src/applications/auth/engine/PhabricatorAuthSessionEngineExtensionModule.php
--- a/src/applications/auth/engine/PhabricatorAuthSessionEngineExtensionModule.php
+++ b/src/applications/auth/engine/PhabricatorAuthSessionEngineExtensionModule.php
@@ -43,6 +43,7 @@
return id(new PHUIObjectBoxView())
->setHeaderText(pht('SessionEngine Extensions'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/auth/tokentype/PhabricatorAuthTemporaryTokenTypeModule.php b/src/applications/auth/tokentype/PhabricatorAuthTemporaryTokenTypeModule.php
--- a/src/applications/auth/tokentype/PhabricatorAuthTemporaryTokenTypeModule.php
+++ b/src/applications/auth/tokentype/PhabricatorAuthTemporaryTokenTypeModule.php
@@ -41,6 +41,7 @@
return id(new PHUIObjectBoxView())
->setHeaderText(pht('Temporary Token Types'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/config/application/PhabricatorConfigApplication.php b/src/applications/config/application/PhabricatorConfigApplication.php
--- a/src/applications/config/application/PhabricatorConfigApplication.php
+++ b/src/applications/config/application/PhabricatorConfigApplication.php
@@ -38,6 +38,7 @@
return array(
'/config/' => array(
'' => 'PhabricatorConfigListController',
+ 'application/' => 'PhabricatorConfigApplicationController',
'all/' => 'PhabricatorConfigAllController',
'history/' => 'PhabricatorConfigHistoryController',
'edit/(?P<key>[\w\.\-]+)/' => 'PhabricatorConfigEditController',
diff --git a/src/applications/config/controller/PhabricatorConfigAllController.php b/src/applications/config/controller/PhabricatorConfigAllController.php
--- a/src/applications/config/controller/PhabricatorConfigAllController.php
+++ b/src/applications/config/controller/PhabricatorConfigAllController.php
@@ -54,9 +54,12 @@
->buildApplicationCrumbs()
->addTextCrumb($title);
- $panel = new PHUIObjectBoxView();
- $panel->setHeaderText(pht('Current Settings'));
- $panel->setTable($table);
+ $versions = $this->renderModuleStatus($viewer);
+
+ $panel = id(new PHUIObjectBoxView())
+ ->setHeaderText(pht('Current Settings'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
+ ->setTable($table);
$nav = $this->buildSideNavView();
$nav->selectFilter('all/');
@@ -64,6 +67,7 @@
$view = id(new PHUITwoColumnView())
->setNavigation($nav)
->setMainColumn(array(
+ $versions,
$panel,
));
@@ -74,4 +78,64 @@
}
+ public function renderModuleStatus($viewer) {
+ $versions = $this->loadVersions($viewer);
+
+ $version_property_list = id(new PHUIPropertyListView());
+ foreach ($versions as $name => $version) {
+ $version_property_list->addProperty($name, $version);
+ }
+
+ $object_box = id(new PHUIObjectBoxView())
+ ->setHeaderText(pht('Current Versions'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
+ ->addPropertyList($version_property_list);
+
+ $phabricator_root = dirname(phutil_get_library_root('phabricator'));
+ $version_path = $phabricator_root.'/conf/local/VERSION';
+ if (Filesystem::pathExists($version_path)) {
+ $version_from_file = Filesystem::readFile($version_path);
+ $version_property_list->addProperty(
+ pht('Local Version'),
+ $version_from_file);
+ }
+
+ return $object_box;
+ }
+
+ private function loadVersions(PhabricatorUser $viewer) {
+ $specs = array(
+ 'phabricator',
+ 'arcanist',
+ 'phutil',
+ );
+
+ $all_libraries = PhutilBootloader::getInstance()->getAllLibraries();
+ // This puts the core libraries at the top:
+ $other_libraries = array_diff($all_libraries, $specs);
+ $specs = array_merge($specs, $other_libraries);
+
+ $futures = array();
+ foreach ($specs as $lib) {
+ $root = dirname(phutil_get_library_root($lib));
+ $futures[$lib] =
+ id(new ExecFuture('git log --format=%s -n 1 --', '%H %ct'))
+ ->setCWD($root);
+ }
+
+ $results = array();
+ foreach ($futures as $key => $future) {
+ list($err, $stdout) = $future->resolve();
+ if (!$err) {
+ list($hash, $epoch) = explode(' ', $stdout);
+ $version = pht('%s (%s)', $hash, phabricator_date($epoch, $viewer));
+ } else {
+ $version = pht('Unknown');
+ }
+ $results[$key] = $version;
+ }
+
+ return $results;
+ }
+
}
diff --git a/src/applications/config/controller/PhabricatorConfigListController.php b/src/applications/config/controller/PhabricatorConfigApplicationController.php
copy from src/applications/config/controller/PhabricatorConfigListController.php
copy to src/applications/config/controller/PhabricatorConfigApplicationController.php
--- a/src/applications/config/controller/PhabricatorConfigListController.php
+++ b/src/applications/config/controller/PhabricatorConfigApplicationController.php
@@ -1,36 +1,32 @@
<?php
-final class PhabricatorConfigListController
+final class PhabricatorConfigApplicationController
extends PhabricatorConfigController {
public function handleRequest(AphrontRequest $request) {
$viewer = $request->getViewer();
$nav = $this->buildSideNavView();
- $nav->selectFilter('/');
+ $nav->selectFilter('application/');
$groups = PhabricatorApplicationConfigOptions::loadAll();
- $core_list = $this->buildConfigOptionsList($groups, 'core');
$apps_list = $this->buildConfigOptionsList($groups, 'apps');
- $title = pht('Phabricator Configuration');
-
- $core = id(new PHUIObjectBoxView())
- ->setHeaderText($title)
- ->setObjectList($core_list);
+ $title = pht('Application Configuration');
$apps = id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Applications Configuration'))
+ ->setHeaderText($title)
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setObjectList($apps_list);
$crumbs = $this
->buildApplicationCrumbs()
- ->addTextCrumb(pht('Config'), $this->getApplicationURI());
+ ->addTextCrumb(pht('Config'), $this->getApplicationURI())
+ ->addTextCrumb(pht('Applications'));
$view = id(new PHUITwoColumnView())
->setNavigation($nav)
->setMainColumn(array(
- $core,
$apps,
));
diff --git a/src/applications/config/controller/PhabricatorConfigCacheController.php b/src/applications/config/controller/PhabricatorConfigCacheController.php
--- a/src/applications/config/controller/PhabricatorConfigCacheController.php
+++ b/src/applications/config/controller/PhabricatorConfigCacheController.php
@@ -51,6 +51,7 @@
return id(new PHUIObjectBoxView())
->setHeader($header)
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->addPropertyList($properties);
}
@@ -102,6 +103,7 @@
return id(new PHUIObjectBoxView())
->setHeaderText(pht('Data Cache'))
->addPropertyList($properties)
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/config/controller/PhabricatorConfigClusterDatabasesController.php b/src/applications/config/controller/PhabricatorConfigClusterDatabasesController.php
--- a/src/applications/config/controller/PhabricatorConfigClusterDatabasesController.php
+++ b/src/applications/config/controller/PhabricatorConfigClusterDatabasesController.php
@@ -207,6 +207,7 @@
return id(new PHUIObjectBoxView())
->setHeader($header)
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/config/controller/PhabricatorConfigClusterNotificationsController.php b/src/applications/config/controller/PhabricatorConfigClusterNotificationsController.php
--- a/src/applications/config/controller/PhabricatorConfigClusterNotificationsController.php
+++ b/src/applications/config/controller/PhabricatorConfigClusterNotificationsController.php
@@ -157,6 +157,7 @@
return id(new PHUIObjectBoxView())
->setHeader($header)
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/config/controller/PhabricatorConfigClusterRepositoriesController.php b/src/applications/config/controller/PhabricatorConfigClusterRepositoriesController.php
--- a/src/applications/config/controller/PhabricatorConfigClusterRepositoriesController.php
+++ b/src/applications/config/controller/PhabricatorConfigClusterRepositoriesController.php
@@ -253,6 +253,7 @@
return id(new PHUIObjectBoxView())
->setHeader($header)
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/config/controller/PhabricatorConfigController.php b/src/applications/config/controller/PhabricatorConfigController.php
--- a/src/applications/config/controller/PhabricatorConfigController.php
+++ b/src/applications/config/controller/PhabricatorConfigController.php
@@ -12,11 +12,13 @@
$nav = new AphrontSideNavFilterView();
$nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
$nav->addLabel(pht('Configuration'));
- $nav->addFilter('/', pht('Browse Settings'));
- $nav->addFilter('all/', pht('All Settings'));
+ $nav->addFilter('/', pht('Core Settings'));
+ $nav->addFilter('application/', pht('Application Settings'));
$nav->addFilter('history/', pht('Settings History'));
+ $nav->addFilter('all/', pht('All Settings'));
$nav->addLabel(pht('Setup'));
$nav->addFilter('issue/', pht('Setup Issues'));
+ $nav->addFilter('welcome/', pht('Installation Guide'));
$nav->addLabel(pht('Database'));
$nav->addFilter('database/', pht('Database Status'));
$nav->addFilter('dbissue/', pht('Database Issues'));
@@ -26,8 +28,6 @@
$nav->addFilter('cluster/databases/', pht('Database Servers'));
$nav->addFilter('cluster/notifications/', pht('Notification Servers'));
$nav->addFilter('cluster/repositories/', pht('Repository Servers'));
- $nav->addLabel(pht('Welcome'));
- $nav->addFilter('welcome/', pht('Welcome Screen'));
$nav->addLabel(pht('Modules'));
$modules = PhabricatorConfigModule::getAllModules();
diff --git a/src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php b/src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php
--- a/src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php
+++ b/src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php
@@ -149,6 +149,7 @@
$table_box = id(new PHUIObjectBoxView())
->setHeader($this->buildHeaderWithDocumentationLink($title))
->setFormErrors($errors)
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
$nav = $this->buildSideNavView();
diff --git a/src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php b/src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php
--- a/src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php
+++ b/src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php
@@ -165,10 +165,12 @@
$prop_box = id(new PHUIObjectBoxView())
->setHeader($this->buildHeaderWithDocumentationLink($title))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->addPropertyList($properties);
$table_box = id(new PHUIObjectBoxView())
->setHeaderText(pht('Databases'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
return $this->buildResponse($title, array($prop_box, $table_box));
@@ -263,10 +265,12 @@
$prop_box = id(new PHUIObjectBoxView())
->setHeader($this->buildHeaderWithDocumentationLink($title))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->addPropertyList($properties);
$table_box = id(new PHUIObjectBoxView())
->setHeaderText(pht('Database Status'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
return $this->buildResponse($title, array($prop_box, $table_box));
@@ -476,14 +480,17 @@
$prop_box = id(new PHUIObjectBoxView())
->setHeader($this->buildHeaderWithDocumentationLink($title))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->addPropertyList($properties);
$table_box = id(new PHUIObjectBoxView())
->setHeaderText(pht('Database'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table_view);
$key_box = id(new PHUIObjectBoxView())
->setHeaderText(pht('Keys'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($keys_view);
return $this->buildResponse($title, array($prop_box, $table_box, $key_box));
@@ -620,6 +627,7 @@
$box = id(new PHUIObjectBoxView())
->setHeader($this->buildHeaderWithDocumentationLink($title))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->addPropertyList($properties);
return $this->buildResponse($title, $box);
@@ -713,6 +721,7 @@
$box = id(new PHUIObjectBoxView())
->setHeader($this->buildHeaderWithDocumentationLink($title))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->addPropertyList($properties);
return $this->buildResponse($title, $box);
diff --git a/src/applications/config/controller/PhabricatorConfigGroupController.php b/src/applications/config/controller/PhabricatorConfigGroupController.php
--- a/src/applications/config/controller/PhabricatorConfigGroupController.php
+++ b/src/applications/config/controller/PhabricatorConfigGroupController.php
@@ -17,6 +17,7 @@
$list = $this->buildOptionList($options->getOptions());
$box = id(new PHUIObjectBoxView())
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setObjectList($list);
$crumbs = $this
diff --git a/src/applications/config/controller/PhabricatorConfigIssueListController.php b/src/applications/config/controller/PhabricatorConfigIssueListController.php
--- a/src/applications/config/controller/PhabricatorConfigIssueListController.php
+++ b/src/applications/config/controller/PhabricatorConfigIssueListController.php
@@ -27,25 +27,28 @@
if ($important) {
$setup_issues[] = id(new PHUIObjectBoxView())
->setHeaderText(pht('Important Setup Issues'))
- ->setColor(PHUIObjectBoxView::COLOR_RED)
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setObjectList($important);
}
if ($php) {
$setup_issues[] = id(new PHUIObjectBoxView())
->setHeaderText(pht('PHP Setup Issues'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setObjectList($php);
}
if ($mysql) {
$setup_issues[] = id(new PHUIObjectBoxView())
->setHeaderText(pht('MySQL Setup Issues'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setObjectList($mysql);
}
if ($other) {
$setup_issues[] = id(new PHUIObjectBoxView())
->setHeaderText(pht('Other Setup Issues'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setObjectList($other);
}
diff --git a/src/applications/config/controller/PhabricatorConfigListController.php b/src/applications/config/controller/PhabricatorConfigListController.php
--- a/src/applications/config/controller/PhabricatorConfigListController.php
+++ b/src/applications/config/controller/PhabricatorConfigListController.php
@@ -11,18 +11,14 @@
$groups = PhabricatorApplicationConfigOptions::loadAll();
$core_list = $this->buildConfigOptionsList($groups, 'core');
- $apps_list = $this->buildConfigOptionsList($groups, 'apps');
- $title = pht('Phabricator Configuration');
+ $title = pht('Core Configuration');
$core = id(new PHUIObjectBoxView())
->setHeaderText($title)
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setObjectList($core_list);
- $apps = id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Applications Configuration'))
- ->setObjectList($apps_list);
-
$crumbs = $this
->buildApplicationCrumbs()
->addTextCrumb(pht('Config'), $this->getApplicationURI());
@@ -31,7 +27,6 @@
->setNavigation($nav)
->setMainColumn(array(
$core,
- $apps,
));
return $this->newPage()
diff --git a/src/applications/config/module/PhabricatorConfigCollectorsModule.php b/src/applications/config/module/PhabricatorConfigCollectorsModule.php
--- a/src/applications/config/module/PhabricatorConfigCollectorsModule.php
+++ b/src/applications/config/module/PhabricatorConfigCollectorsModule.php
@@ -73,6 +73,7 @@
return id(new PHUIObjectBoxView())
->setHeader($header)
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/config/module/PhabricatorConfigEdgeModule.php b/src/applications/config/module/PhabricatorConfigEdgeModule.php
--- a/src/applications/config/module/PhabricatorConfigEdgeModule.php
+++ b/src/applications/config/module/PhabricatorConfigEdgeModule.php
@@ -41,6 +41,7 @@
return id(new PHUIObjectBoxView())
->setHeaderText(pht('Edge Types'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/config/module/PhabricatorConfigHTTPParameterTypesModule.php b/src/applications/config/module/PhabricatorConfigHTTPParameterTypesModule.php
--- a/src/applications/config/module/PhabricatorConfigHTTPParameterTypesModule.php
+++ b/src/applications/config/module/PhabricatorConfigHTTPParameterTypesModule.php
@@ -21,6 +21,7 @@
return id(new PHUIObjectBoxView())
->setHeaderText(pht('HTTP Parameter Types'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/config/module/PhabricatorConfigPHIDModule.php b/src/applications/config/module/PhabricatorConfigPHIDModule.php
--- a/src/applications/config/module/PhabricatorConfigPHIDModule.php
+++ b/src/applications/config/module/PhabricatorConfigPHIDModule.php
@@ -73,6 +73,7 @@
return id(new PHUIObjectBoxView())
->setHeaderText(pht('PHID Types'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/config/module/PhabricatorConfigRequestExceptionHandlerModule.php b/src/applications/config/module/PhabricatorConfigRequestExceptionHandlerModule.php
--- a/src/applications/config/module/PhabricatorConfigRequestExceptionHandlerModule.php
+++ b/src/applications/config/module/PhabricatorConfigRequestExceptionHandlerModule.php
@@ -41,6 +41,7 @@
return id(new PHUIObjectBoxView())
->setHeaderText(pht('Exception Handlers'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/config/module/PhabricatorConfigSiteModule.php b/src/applications/config/module/PhabricatorConfigSiteModule.php
--- a/src/applications/config/module/PhabricatorConfigSiteModule.php
+++ b/src/applications/config/module/PhabricatorConfigSiteModule.php
@@ -40,6 +40,7 @@
return id(new PHUIObjectBoxView())
->setHeaderText(pht('Sites'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/config/module/PhabricatorConfigVersionsModule.php b/src/applications/config/module/PhabricatorConfigVersionsModule.php
deleted file mode 100644
--- a/src/applications/config/module/PhabricatorConfigVersionsModule.php
+++ /dev/null
@@ -1,75 +0,0 @@
-<?php
-
-final class PhabricatorConfigVersionsModule
- extends PhabricatorConfigModule {
-
- public function getModuleKey() {
- return 'versions';
- }
-
- public function getModuleName() {
- return pht('Versions');
- }
-
- public function renderModuleStatus(AphrontRequest $request) {
- $viewer = $request->getViewer();
-
- $versions = $this->loadVersions($viewer);
-
- $version_property_list = id(new PHUIPropertyListView());
- foreach ($versions as $name => $version) {
- $version_property_list->addProperty($name, $version);
- }
-
- $object_box = id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Current Versions'))
- ->addPropertyList($version_property_list);
-
- $phabricator_root = dirname(phutil_get_library_root('phabricator'));
- $version_path = $phabricator_root.'/conf/local/VERSION';
- if (Filesystem::pathExists($version_path)) {
- $version_from_file = Filesystem::readFile($version_path);
- $version_property_list->addProperty(
- pht('Local Version'),
- $version_from_file);
- }
-
- return $object_box;
- }
-
- private function loadVersions(PhabricatorUser $viewer) {
- $specs = array(
- 'phabricator',
- 'arcanist',
- 'phutil',
- );
-
- $all_libraries = PhutilBootloader::getInstance()->getAllLibraries();
- // This puts the core libraries at the top:
- $other_libraries = array_diff($all_libraries, $specs);
- $specs = array_merge($specs, $other_libraries);
-
- $futures = array();
- foreach ($specs as $lib) {
- $root = dirname(phutil_get_library_root($lib));
- $futures[$lib] =
- id(new ExecFuture('git log --format=%s -n 1 --', '%H %ct'))
- ->setCWD($root);
- }
-
- $results = array();
- foreach ($futures as $key => $future) {
- list($err, $stdout) = $future->resolve();
- if (!$err) {
- list($hash, $epoch) = explode(' ', $stdout);
- $version = pht('%s (%s)', $hash, phabricator_date($epoch, $viewer));
- } else {
- $version = pht('Unknown');
- }
- $results[$key] = $version;
- }
-
- return $results;
- }
-
-}
diff --git a/src/applications/search/engineextension/PhabricatorHovercardEngineExtensionModule.php b/src/applications/search/engineextension/PhabricatorHovercardEngineExtensionModule.php
--- a/src/applications/search/engineextension/PhabricatorHovercardEngineExtensionModule.php
+++ b/src/applications/search/engineextension/PhabricatorHovercardEngineExtensionModule.php
@@ -49,6 +49,7 @@
return id(new PHUIObjectBoxView())
->setHeaderText(pht('HovercardEngine Extensions'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/search/engineextension/PhabricatorSearchEngineExtensionModule.php b/src/applications/search/engineextension/PhabricatorSearchEngineExtensionModule.php
--- a/src/applications/search/engineextension/PhabricatorSearchEngineExtensionModule.php
+++ b/src/applications/search/engineextension/PhabricatorSearchEngineExtensionModule.php
@@ -49,6 +49,7 @@
return id(new PHUIObjectBoxView())
->setHeaderText(pht('SearchEngine Extensions'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/search/index/PhabricatorFulltextEngineExtensionModule.php b/src/applications/search/index/PhabricatorFulltextEngineExtensionModule.php
--- a/src/applications/search/index/PhabricatorFulltextEngineExtensionModule.php
+++ b/src/applications/search/index/PhabricatorFulltextEngineExtensionModule.php
@@ -38,6 +38,7 @@
return id(new PHUIObjectBoxView())
->setHeaderText(pht('FulltextEngine Extensions'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/search/index/PhabricatorIndexEngineExtensionModule.php b/src/applications/search/index/PhabricatorIndexEngineExtensionModule.php
--- a/src/applications/search/index/PhabricatorIndexEngineExtensionModule.php
+++ b/src/applications/search/index/PhabricatorIndexEngineExtensionModule.php
@@ -38,6 +38,7 @@
return id(new PHUIObjectBoxView())
->setHeaderText(pht('IndexEngine Extensions'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/system/engine/PhabricatorDestructionEngineExtensionModule.php b/src/applications/system/engine/PhabricatorDestructionEngineExtensionModule.php
--- a/src/applications/system/engine/PhabricatorDestructionEngineExtensionModule.php
+++ b/src/applications/system/engine/PhabricatorDestructionEngineExtensionModule.php
@@ -38,6 +38,7 @@
return id(new PHUIObjectBoxView())
->setHeaderText(pht('DestructionEngine Extensions'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/applications/transactions/engineextension/PhabricatorEditEngineExtensionModule.php b/src/applications/transactions/engineextension/PhabricatorEditEngineExtensionModule.php
--- a/src/applications/transactions/engineextension/PhabricatorEditEngineExtensionModule.php
+++ b/src/applications/transactions/engineextension/PhabricatorEditEngineExtensionModule.php
@@ -46,6 +46,7 @@
return id(new PHUIObjectBoxView())
->setHeaderText(pht('EditEngine Extensions'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
diff --git a/src/infrastructure/contentsource/PhabricatorContentSourceModule.php b/src/infrastructure/contentsource/PhabricatorContentSourceModule.php
--- a/src/infrastructure/contentsource/PhabricatorContentSourceModule.php
+++ b/src/infrastructure/contentsource/PhabricatorContentSourceModule.php
@@ -45,6 +45,7 @@
return id(new PHUIObjectBoxView())
->setHeaderText(pht('Content Sources'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setTable($table);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Feb 22, 9:41 PM (5 h, 32 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7182806
Default Alt Text
D16429.id39508.diff (28 KB)
Attached To
Mode
D16429: Update Config Application UI
Attached
Detach File
Event Timeline
Log In to Comment