Page MenuHomePhabricator

Update Config Application UI
ClosedPublic

Authored by chad on Aug 22 2016, 3:44 AM.
Tags
None
Referenced Files
F14058883: D16429.diff
Sun, Nov 17, 3:37 PM
F14044834: D16429.id39510.diff
Tue, Nov 12, 9:48 PM
F14027887: D16429.diff
Fri, Nov 8, 10:06 AM
F13990720: D16429.diff
Tue, Oct 22, 5:36 AM
F13987318: D16429.id39511.diff
Mon, Oct 21, 8:42 AM
F13967714: D16429.id.diff
Oct 16 2024, 3:27 PM
Unknown Object (File)
Oct 9 2024, 7:50 PM
Unknown Object (File)
Oct 9 2024, 7:10 PM
Subscribers

Details

Summary

Switches over to new property UI boxes, splits core and apps into separate pages. Move Versions into "All Settings". I think there is some docs I likely need to update here as well.

Test Plan

Click on each item in the sidebar, see new headers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Update Config Application UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.

I'm hesitant about moving "Versions" into "All Settings":

  • We describe how to get this information in Providing Version Information, and changing it will confuse users filing reports more than they're already confused (the instructions won't work any more for users who aren't up to date if we make this change).
  • Users have a hard time reporting this information consistently even though it says "Version" right now. It's unintuitive to me that "Version" is in "All Settings"; I would never guess that I needed to click that even if I knew that version information was in Config somewhere.
  • After T5055, I expect this page to show more information (versions of all installed extensions, plus information about them), none of which will be related to settings.

Of all the stuff here, I generally think "Versions" is one of the most important items? What's the goal in merging it?

If you just want to clean up the number of items here, I'd rather get rid of other stuff -- maybe we can divide this application into multiple applications ("Config" vs "Setup"? -- although I think that also risks confusion) or put a dashboard with bigger categories here as the landing page and then dump you into smaller sub-sections?

The code is fine, this just seems like a small step backward in getting good bug reports and I'm not sure what we gain by merging the sections.

I mostly want to move "Versions" up from under the fold. I was tempted to go further and have it just at the top of the /, so it was always available when you land in Config? Alternatively I can just make it a Controller instead of a Module and place it up under "All Settings".

Alternatively I can just make it a Controller instead of a Module and place it up under "All Settings".

Ah! That sounds good to me. I think it'll get expanded in T5055 anyway and probably want to become a controller at that point regardless.

epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 22 2016, 5:15 PM
chad edited edge metadata.
  • Make Versions it's own controller
  • remove version info from all settings
This revision was automatically updated to reflect the committed changes.