Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14895268
D21142.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D21142.diff
View Options
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -3274,7 +3274,6 @@
'PhabricatorEditorExtension' => 'applications/transactions/engineextension/PhabricatorEditorExtension.php',
'PhabricatorEditorExtensionModule' => 'applications/transactions/engineextension/PhabricatorEditorExtensionModule.php',
'PhabricatorEditorMailEngineExtension' => 'applications/transactions/engineextension/PhabricatorEditorMailEngineExtension.php',
- 'PhabricatorEditorMultipleSetting' => 'applications/settings/setting/PhabricatorEditorMultipleSetting.php',
'PhabricatorEditorSetting' => 'applications/settings/setting/PhabricatorEditorSetting.php',
'PhabricatorElasticFulltextStorageEngine' => 'applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php',
'PhabricatorElasticsearchHost' => 'infrastructure/cluster/search/PhabricatorElasticsearchHost.php',
@@ -9735,7 +9734,6 @@
'PhabricatorEditorExtension' => 'Phobject',
'PhabricatorEditorExtensionModule' => 'PhabricatorConfigModule',
'PhabricatorEditorMailEngineExtension' => 'PhabricatorMailEngineExtension',
- 'PhabricatorEditorMultipleSetting' => 'PhabricatorSelectSetting',
'PhabricatorEditorSetting' => 'PhabricatorStringSetting',
'PhabricatorElasticFulltextStorageEngine' => 'PhabricatorFulltextStorageEngine',
'PhabricatorElasticsearchHost' => 'PhabricatorSearchHost',
diff --git a/src/applications/people/storage/PhabricatorUser.php b/src/applications/people/storage/PhabricatorUser.php
--- a/src/applications/people/storage/PhabricatorUser.php
+++ b/src/applications/people/storage/PhabricatorUser.php
@@ -478,19 +478,6 @@
$editor = $this->getUserSetting(PhabricatorEditorSetting::SETTINGKEY);
- if (is_array($path)) {
- $multi_key = PhabricatorEditorMultipleSetting::SETTINGKEY;
- $multiedit = $this->getUserSetting($multi_key);
- switch ($multiedit) {
- case PhabricatorEditorMultipleSetting::VALUE_SPACES:
- $path = implode(' ', $path);
- break;
- case PhabricatorEditorMultipleSetting::VALUE_SINGLE:
- default:
- return null;
- }
- }
-
if (!strlen($editor)) {
return null;
}
diff --git a/src/applications/settings/setting/PhabricatorEditorMultipleSetting.php b/src/applications/settings/setting/PhabricatorEditorMultipleSetting.php
deleted file mode 100644
--- a/src/applications/settings/setting/PhabricatorEditorMultipleSetting.php
+++ /dev/null
@@ -1,40 +0,0 @@
-<?php
-
-final class PhabricatorEditorMultipleSetting
- extends PhabricatorSelectSetting {
-
- const SETTINGKEY = 'multiedit';
-
- const VALUE_SPACES = 'spaces';
- const VALUE_SINGLE = 'disable';
-
- public function getSettingName() {
- return pht('Edit Multiple Files');
- }
-
- public function getSettingPanelKey() {
- return PhabricatorExternalEditorSettingsPanel::PANELKEY;
- }
-
- protected function getSettingOrder() {
- return 400;
- }
-
- protected function getControlInstructions() {
- return pht(
- 'Some editors support opening multiple files with a single URI. You '.
- 'can specify the behavior of your editor here.');
- }
-
- public function getSettingDefaultValue() {
- return self::VALUE_SPACES;
- }
-
- protected function getSelectOptions() {
- return array(
- self::VALUE_SPACES => pht('Supported, Separated by Spaces'),
- self::VALUE_SINGLE => pht('Not Supported'),
- );
- }
-
-}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Feb 10, 9:01 AM (2 h, 53 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7116416
Default Alt Text
D21142.diff (3 KB)
Attached To
Mode
D21142: Remove the "Edit Multiple Files" external editor setting
Attached
Detach File
Event Timeline
Log In to Comment