Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14834159
D8842.id20979.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
971 B
Referenced Files
None
Subscribers
None
D8842.id20979.diff
View Options
diff --git a/src/applications/differential/query/DifferentialHunkQuery.php b/src/applications/differential/query/DifferentialHunkQuery.php
--- a/src/applications/differential/query/DifferentialHunkQuery.php
+++ b/src/applications/differential/query/DifferentialHunkQuery.php
@@ -17,6 +17,19 @@
return $this;
}
+ public function willExecute() {
+ // If we fail to load any hunks at all (for example, because all of
+ // the requested changesets are directories or empty files and have no
+ // hunks) we'll never call didFilterPage(), and thus never have an
+ // opportunity to attach hunks. Attach empty hunk lists now so that we
+ // end up with the right result.
+ if ($this->shouldAttachToChangesets) {
+ foreach ($this->changesets as $changeset) {
+ $changeset->attachHunks(array());
+ }
+ }
+ }
+
public function loadPage() {
$table = new DifferentialHunk();
$conn_r = $table->establishConnection('r');
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Jan 31, 2:17 PM (13 h, 18 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7078754
Default Alt Text
D8842.id20979.diff (971 B)
Attached To
Mode
D8842: Fix a HunkQuery issue where no hunks load at all
Attached
Detach File
Event Timeline
Log In to Comment