Page MenuHomePhabricator

Fix a HunkQuery issue where no hunks load at all
ClosedPublic

Authored by epriestley on Apr 22 2014, 10:29 PM.
Tags
None
Referenced Files
F15445632: D8842.id.diff
Thu, Mar 27, 3:07 PM
F15443673: D8842.id20979.diff
Thu, Mar 27, 5:36 AM
F15440845: D8842.diff
Wed, Mar 26, 2:57 PM
F15424401: D8842.id20993.diff
Sat, Mar 22, 10:03 PM
F15391431: D8842.id20993.diff
Sat, Mar 15, 9:50 AM
F15391171: D8842.id20993.diff
Sat, Mar 15, 8:32 AM
F15390060: D8842.id.diff
Sat, Mar 15, 5:52 AM
F15388167: D8842.diff
Sat, Mar 15, 3:24 AM
Subscribers

Details

Summary

If you create a diff with no hunks (e.g., it adds a single empty file), we never attachHunks() so we throw on getHunks().

Instead, make sure changesets get hunks attached if they expect it.

Test Plan

Created a new diff with a single empty file in it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix a HunkQuery issue where no hunks load at all.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

@zeeg, this should fix the issue you ran into yesterday.

btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 23 2014, 7:00 PM
epriestley updated this revision to Diff 20993.

Closed by commit rP5f033d580c58 (authored by @epriestley).