Page MenuHomePhabricator

Fix a HunkQuery issue where no hunks load at all
ClosedPublic

Authored by epriestley on Apr 22 2014, 10:29 PM.
Tags
None
Referenced Files
F19813449: D8842.diff
Wed, Mar 4, 9:31 AM
F19527273: D8842.id20979.diff
Jan 19 2026, 12:07 AM
F19204476: D8842.id20979.diff
Dec 16 2025, 7:03 PM
F18934086: D8842.id.diff
Nov 10 2025, 1:04 PM
F18920784: D8842.diff
Nov 9 2025, 1:20 PM
F18819687: D8842.diff
Oct 22 2025, 8:33 AM
F18761262: D8842.id.diff
Oct 6 2025, 1:18 PM
F18756747: D8842.diff
Oct 5 2025, 1:16 PM
Subscribers

Details

Summary

If you create a diff with no hunks (e.g., it adds a single empty file), we never attachHunks() so we throw on getHunks().

Instead, make sure changesets get hunks attached if they expect it.

Test Plan

Created a new diff with a single empty file in it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix a HunkQuery issue where no hunks load at all.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

@zeeg, this should fix the issue you ran into yesterday.

btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 23 2014, 7:00 PM
epriestley updated this revision to Diff 20993.

Closed by commit rP5f033d580c58 (authored by @epriestley).