Page MenuHomePhabricator

Fix a HunkQuery issue where no hunks load at all
ClosedPublic

Authored by epriestley on Apr 22 2014, 10:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 26, 12:20 PM
Unknown Object (File)
Tue, Feb 11, 4:41 AM
Unknown Object (File)
Sun, Feb 9, 12:24 PM
Unknown Object (File)
Sat, Feb 8, 8:13 PM
Unknown Object (File)
Sun, Feb 2, 3:20 AM
Unknown Object (File)
Jan 30 2025, 2:17 PM
Unknown Object (File)
Jan 23 2025, 9:32 PM
Unknown Object (File)
Jan 23 2025, 9:32 PM
Subscribers

Details

Summary

If you create a diff with no hunks (e.g., it adds a single empty file), we never attachHunks() so we throw on getHunks().

Instead, make sure changesets get hunks attached if they expect it.

Test Plan

Created a new diff with a single empty file in it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix a HunkQuery issue where no hunks load at all.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

@zeeg, this should fix the issue you ran into yesterday.

btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 23 2014, 7:00 PM
epriestley updated this revision to Diff 20993.

Closed by commit rP5f033d580c58 (authored by @epriestley).