Page MenuHomePhabricator

D18730.id44962.diff
No OneTemporary

D18730.id44962.diff

diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -1537,7 +1537,13 @@
if ($object->isDraft() && $auto_undraft) {
$active_builds = $this->hasActiveBuilds($object);
if (!$active_builds) {
+ // When Harbormaster moves a revision out of the draft state, we
+ // attribute the action to the revision author since this is more
+ // natural and more useful.
+ $author_phid = $object->getAuthorPHID();
+
$xaction = $object->getApplicationTransactionTemplate()
+ ->setAuthorPHID($author_phid)
->setTransactionType(
DifferentialRevisionRequestReviewTransaction::TRANSACTIONTYPE)
->setOldValue(false)

File Metadata

Mime Type
text/plain
Expires
Thu, Jan 23, 5:27 AM (11 h, 5 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7028666
Default Alt Text
D18730.id44962.diff (955 B)

Event Timeline