Page MenuHomePhabricator

Attribute revision promotion from "Draft" to "Needs Review" to the author
ClosedPublic

Authored by epriestley on Oct 24 2017, 4:32 PM.

Details

Summary

Ref T2543. When Harbormaster finishes builds and promotes a draft revision to review, we currently publish "Harbormaster requested review of...".

Instead, attribute this action to the author, since that's more natural and more useful.

Test Plan

Promoted a diff locally, saw it attributed to me rather than Harbormaster.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Oct 24 2017, 4:32 PM
Harbormaster requested review of this revision.Oct 24 2017, 4:33 PM
Harbormaster completed remote builds in B18740: Diff 44960.
amckinley accepted this revision.Oct 25 2017, 4:14 PM
This revision is now accepted and ready to land.Oct 25 2017, 4:14 PM
This revision was automatically updated to reflect the committed changes.