Differential D18730

Attribute revision promotion from "Draft" to "Needs Review" to the author
ClosedPublic
Actions

Authored by epriestley on Oct 24 2017, 4:32 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential

Commits

rPbeaf0ad9a636: Attribute revision promotion from "Draft" to "Needs Review" to the author

Summary

Ref T2543. When Harbormaster finishes builds and promotes a draft revision to review, we currently publish "Harbormaster requested review of...".

Instead, attribute this action to the author, since that's more natural and more useful.

Test Plan

Promoted a diff locally, saw it attributed to me rather than Harbormaster.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 24 2017, 4:32 PM

Harbormaster requested review of this revision.Oct 24 2017, 4:33 PM

Harbormaster completed remote builds in B18740: Diff 44960.

amckinley accepted this revision.Oct 25 2017, 4:14 PM

This revision is now accepted and ready to land.Oct 25 2017, 4:14 PM

Closed by commit rPbeaf0ad9a636: Attribute revision promotion from "Draft" to "Needs Review" to the author (authored by epriestley). · Explain WhyOct 26 2017, 7:57 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D18732: Add a missing `artifactIndex` key to HarbormasterBuildArtifact.Oct 26 2017, 10:32 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

6 lines

Diff 44962

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Attribute revision promotion from "Draft" to "Needs Review" to the authorClosedPublicActions