Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14757443
D20326.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D20326.diff
View Options
diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -433,7 +433,7 @@
'rsrc/js/application/transactions/behavior-show-older-transactions.js' => '600f440c',
'rsrc/js/application/transactions/behavior-transaction-comment-form.js' => '2bdadf1a',
'rsrc/js/application/transactions/behavior-transaction-list.js' => '9cec214e',
- 'rsrc/js/application/trigger/TriggerRule.js' => 'e4a816a4',
+ 'rsrc/js/application/trigger/TriggerRule.js' => '1c60c3fc',
'rsrc/js/application/trigger/TriggerRuleControl.js' => '5faf27b9',
'rsrc/js/application/trigger/TriggerRuleEditor.js' => 'b49fd60c',
'rsrc/js/application/trigger/TriggerRuleType.js' => '4feea7d3',
@@ -894,7 +894,7 @@
'syntax-default-css' => '055fc231',
'syntax-highlighting-css' => '4234f572',
'tokens-css' => 'ce5a50bd',
- 'trigger-rule' => 'e4a816a4',
+ 'trigger-rule' => '1c60c3fc',
'trigger-rule-control' => '5faf27b9',
'trigger-rule-editor' => 'b49fd60c',
'trigger-rule-type' => '4feea7d3',
diff --git a/webroot/rsrc/js/application/trigger/TriggerRule.js b/webroot/rsrc/js/application/trigger/TriggerRule.js
--- a/webroot/rsrc/js/application/trigger/TriggerRule.js
+++ b/webroot/rsrc/js/application/trigger/TriggerRule.js
@@ -84,8 +84,8 @@
control.value = this.getType();
- var on_change = JX.bind(this, this._onTypeChange);
- JX.DOM.listen(control, 'onchange', null, on_change);
+ var on_change = JX.bind(this, this._onTypeChange, control);
+ JX.DOM.listen(control, 'change', null, on_change);
var attributes = {
className: 'type-cell'
@@ -97,10 +97,8 @@
return this._typeCell;
},
- _onTypeChange: function() {
- var control = this._getTypeCell();
+ _onTypeChange: function(control) {
this.setType(control.value);
-
this._rebuildValueControl();
},
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Jan 23, 1:11 AM (11 h, 4 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7035751
Default Alt Text
D20326.diff (1 KB)
Attached To
Mode
D20326: When changing the trigger type in the trigger editor, properly redraw the control
Attached
Detach File
Event Timeline
Log In to Comment