Page MenuHomePhabricator

D18493.diff
No OneTemporary

D18493.diff

diff --git a/src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php
--- a/src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php
@@ -218,7 +218,11 @@
'dateCreated' => $revision->getDateCreated(),
'dateModified' => $revision->getDateModified(),
'authorPHID' => $revision->getAuthorPHID(),
- 'status' => $revision->getLegacyRevisionStatus(),
+
+ // NOTE: For backward compatibility this is explicitly a string, like
+ // "2", even though the value of the string is an integer. See PHI14.
+ 'status' => (string)$revision->getLegacyRevisionStatus(),
+
'statusName' => $revision->getStatusDisplayName(),
'properties' => $revision->getProperties(),
'branch' => $diff->getBranch(),

File Metadata

Mime Type
text/plain
Expires
Wed, Jan 22, 9:27 AM (2 h, 24 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7028124
Default Alt Text
D18493.diff (1 KB)

Event Timeline