Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14737146
D8296.id19734.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D8296.id19734.diff
View Options
diff --git a/src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php b/src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php
--- a/src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php
+++ b/src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php
@@ -90,7 +90,7 @@
foreach ($this->ccs as $phid) {
$handle = $this->getHandle($phid);
if ($handle->isComplete()) {
- $names[] = $handle->getName();
+ $names[] = $handle->getObjectName();
}
}
return implode(', ', $names);
diff --git a/src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php b/src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php
--- a/src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php
+++ b/src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php
@@ -130,8 +130,6 @@
return null;
}
- $project_type = PhabricatorProjectPHIDTypeProject::TYPECONST;
-
$names = array();
foreach ($this->reviewers as $phid) {
$names[] = $this->getHandle($phid)->getObjectName();
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Jan 20, 3:27 AM (13 h, 22 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7022292
Default Alt Text
D8296.id19734.diff (1 KB)
Attached To
Mode
D8296: Fix (?) an issue with CCs not being written into commit messages properly
Attached
Detach File
Event Timeline
Log In to Comment