Fix (?) an issue with CCs not being written into commit messages properly
ClosedPublic
Actions

Authored by epriestley on Feb 21 2014, 8:17 PM.

Tags

None

Referenced Files

	F17814052: D8296.id.diff
	Fri, Jul 25, 8:49 PM

	F17787825: D8296.diff
	Thu, Jul 24, 4:51 PM

	F17759453: D8296.diff
	Tue, Jul 22, 6:29 PM

	Unknown Object (File)
	Jun 17 2025, 11:34 PM

	Unknown Object (File)
	May 26 2025, 8:19 PM

	Unknown Object (File)
	May 8 2025, 6:08 AM

	Unknown Object (File)
	May 6 2025, 9:10 AM

	Unknown Object (File)
	May 6 2025, 9:10 AM

View All Files

Subscribers

aran

zeeg

Details

Reviewers

zeeg
btrahan

Commits

Restricted Diffusion Commit
rPa84cc1ab731a: Fix (?) an issue with CCs not being written into commit messages properly

Summary

Report from @zeeg, I think this is the root issue. Currently, if a project is CC'd we'll write "CC: projectname", but should write "CC: #projectname".

Test Plan

Verified that we now write "CC: #projectname".

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Feb 21 2014, 8:24 PM

lgtm

noidea

Closed by commit rPa84cc1ab731a (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

field/

specification/

DifferentialCCsFieldSpecification.php

2 lines

DifferentialReviewersFieldSpecification.php

2 lines

Diff 19739

View Options

src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php