Fix (?) an issue with CCs not being written into commit messages properly
ClosedPublic
Actions

Authored by epriestley on Feb 21 2014, 8:17 PM.

Tags

None

Referenced Files

	F13350251: D8296.diff
	Sun, Jun 23, 6:26 AM

	F13272314: D8296.diff
	May 30 2024, 12:41 PM

	F13262966: D8296.id19739.diff
	May 27 2024, 5:25 AM

	F13258600: D8296.diff
	May 26 2024, 11:04 AM

	F13239263: D8296.diff
	May 22 2024, 1:34 AM

	F13238073: D8296.id.diff
	May 21 2024, 4:57 PM

	F13217238: D8296.diff
	May 18 2024, 4:10 AM

	F13206112: D8296.id19734.diff
	May 15 2024, 5:15 AM

View All Files

Subscribers

aran

zeeg

Details

Reviewers

zeeg
btrahan

Commits

Restricted Diffusion Commit
rPa84cc1ab731a: Fix (?) an issue with CCs not being written into commit messages properly

Summary

Report from @zeeg, I think this is the root issue. Currently, if a project is CC'd we'll write "CC: projectname", but should write "CC: #projectname".

Test Plan

Verified that we now write "CC: #projectname".

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Feb 21 2014, 8:24 PM

lgtm

noidea

Closed by commit rPa84cc1ab731a (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

field/

specification/

DifferentialCCsFieldSpecification.php

2 lines

DifferentialReviewersFieldSpecification.php

2 lines

Diff 19739

View Options

src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php