Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14612508
D20514.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
607 B
Referenced Files
None
Subscribers
None
D20514.diff
View Options
diff --git a/src/lint/linter/ArcanistLinter.php b/src/lint/linter/ArcanistLinter.php
--- a/src/lint/linter/ArcanistLinter.php
+++ b/src/lint/linter/ArcanistLinter.php
@@ -214,9 +214,6 @@
return 1.0;
}
- /**
- * TODO: This should be `final`.
- */
public function setCustomSeverityMap(array $map) {
$this->customSeverityMap = $map;
return $this;
@@ -227,7 +224,7 @@
return $this;
}
- final public function setCustomSeverityRules(array $rules) {
+ public function setCustomSeverityRules(array $rules) {
$this->customSeverityRules = $rules;
return $this;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Jan 10, 1:25 PM (14 h, 47 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6982821
Default Alt Text
D20514.diff (607 B)
Attached To
Mode
D20514: Allow `setCustomSeverityRules` to be overridden in subclasses
Attached
Detach File
Event Timeline
Log In to Comment