Page MenuHomePhabricator
Files F14588291

D20542.diff
No OneTemporary
Actions

D20542.diff
View Options

diff --git a/src/lint/linter/__tests__/ArcanistClosureLinterTestCase.php b/src/lint/linter/__tests__/ArcanistClosureLinterTestCase.php
--- a/src/lint/linter/__tests__/ArcanistClosureLinterTestCase.php
+++ b/src/lint/linter/__tests__/ArcanistClosureLinterTestCase.php
@@ -3,6 +3,11 @@
final class ArcanistClosureLinterTestCase
extends ArcanistExternalLinterTestCase {
+ public function testVersion() {
+ $this->assertSkipped(
+ pht("We don't currently parse the version from this linter."));
+ }
+
protected function getLinter() {
$linter = new ArcanistClosureLinter();
$linter->setFlags(array('--additional_extensions=lint-test'));
diff --git a/src/lint/linter/__tests__/ArcanistCpplintLinterTestCase.php b/src/lint/linter/__tests__/ArcanistCpplintLinterTestCase.php
--- a/src/lint/linter/__tests__/ArcanistCpplintLinterTestCase.php
+++ b/src/lint/linter/__tests__/ArcanistCpplintLinterTestCase.php
@@ -3,6 +3,11 @@
final class ArcanistCpplintLinterTestCase
extends ArcanistExternalLinterTestCase {
+ public function testVersion() {
+ $this->assertSkipped(
+ pht("We don't currently parse the version from this linter."));
+ }
+
public function testLinter() {
$this->executeTestsInDirectory(dirname(__FILE__).'/cpplint/');
}
diff --git a/src/lint/linter/__tests__/ArcanistExternalLinterTestCase.php b/src/lint/linter/__tests__/ArcanistExternalLinterTestCase.php
--- a/src/lint/linter/__tests__/ArcanistExternalLinterTestCase.php
+++ b/src/lint/linter/__tests__/ArcanistExternalLinterTestCase.php
@@ -2,11 +2,11 @@
abstract class ArcanistExternalLinterTestCase extends ArcanistLinterTestCase {
- final public function testVersion() {
+ public function testVersion() {
try {
$version = $this->getLinter()->getVersion();
$this->assertTrue(
- $version !== false,
+ strlen($version) > 0,
pht('Failed to parse version from command.'));
} catch (ArcanistMissingLinterException $ex) {
$this->assertSkipped($ex->getMessage());
diff --git a/src/lint/linter/__tests__/ArcanistGoLintLinterTestCase.php b/src/lint/linter/__tests__/ArcanistGoLintLinterTestCase.php
--- a/src/lint/linter/__tests__/ArcanistGoLintLinterTestCase.php
+++ b/src/lint/linter/__tests__/ArcanistGoLintLinterTestCase.php
@@ -3,6 +3,11 @@
final class ArcanistGoLintLinterTestCase
extends ArcanistExternalLinterTestCase {
+ public function testVersion() {
+ $this->assertSkipped(
+ pht("We don't currently parse the version from this linter."));
+ }
+
public function testLinter() {
$this->executeTestsInDirectory(dirname(__FILE__).'/golint/');
}

File Metadata

Mime Type
text/plain
Expires
Thu, Jan 9, 11:18 AM (6 h, 46 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6978726
Default Alt Text
D20542.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility