Page MenuHomePhabricator
Files F14477627

D18468.id44363.diff
No OneTemporary
Actions

D18468.id44363.diff
View Options

diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -107,20 +107,6 @@
return parent::getCustomTransactionNewValue($object, $xaction);
}
- protected function transactionHasEffect(
- PhabricatorLiskDAO $object,
- PhabricatorApplicationTransaction $xaction) {
-
- $actor_phid = $this->getActingAsPHID();
-
- switch ($xaction->getTransactionType()) {
- case DifferentialTransaction::TYPE_INLINE:
- return $xaction->hasComment();
- }
-
- return parent::transactionHasEffect($object, $xaction);
- }
-
protected function applyCustomInternalTransaction(
PhabricatorLiskDAO $object,
PhabricatorApplicationTransaction $xaction) {
diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -486,8 +486,6 @@
switch ($xaction->getTransactionType()) {
case PhabricatorTransactions::TYPE_CREATE:
return true;
- case PhabricatorTransactions::TYPE_COMMENT:
- return $xaction->hasComment();
case PhabricatorTransactions::TYPE_CUSTOMFIELD:
$field = $this->getCustomFieldForTransaction($object, $xaction);
return $field->getApplicationTransactionHasEffect($xaction);
@@ -534,6 +532,10 @@
$xaction->getNewValue());
}
+ if ($xaction->hasComment()) {
+ return true;
+ }
+
return ($xaction->getOldValue() !== $xaction->getNewValue());
}

File Metadata

Mime Type
text/plain
Expires
Sun, Dec 29, 2:53 PM (2 h, 54 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6942592
Default Alt Text
D18468.id44363.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility