Page MenuHomePhabricator

D20562.diff
No OneTemporary

D20562.diff

diff --git a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
--- a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
+++ b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
@@ -127,7 +127,19 @@
}
public function hasComment() {
- return $this->getComment() && strlen($this->getComment()->getContent());
+ if (!$this->getComment()) {
+ return false;
+ }
+
+ $content = $this->getComment()->getContent();
+
+ // If the content is empty or consists of only whitespace, don't count
+ // this as comment.
+ if (!strlen(trim($content))) {
+ return false;
+ }
+
+ return true;
}
public function getComment() {

File Metadata

Mime Type
text/plain
Expires
Wed, Dec 25, 12:36 PM (10 h, 54 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6926273
Default Alt Text
D20562.diff (814 B)

Event Timeline