Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14412005
D19361.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
912 B
Referenced Files
None
Subscribers
None
D19361.diff
View Options
diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -850,11 +850,13 @@
$revert_phids = array();
}
- $this->setUnmentionablePHIDMap(
- array_merge(
- $task_phids,
- $rev_phids,
- $revert_phids));
+ // See PHI574. Respect any unmentionable PHIDs which were set on the
+ // Editor by the caller.
+ $unmentionable_map = $this->getUnmentionablePHIDMap();
+ $unmentionable_map += $task_phids;
+ $unmentionable_map += $rev_phids;
+ $unmentionable_map += $revert_phids;
+ $this->setUnmentionablePHIDMap($unmentionable_map);
$result = array();
foreach ($edges as $type => $specs) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Dec 25, 12:28 PM (11 h, 35 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6926253
Default Alt Text
D19361.diff (912 B)
Attached To
Mode
D19361: Respect external unmentionable PHIDs in Differential revision editor
Attached
Detach File
Event Timeline
Log In to Comment