Files F14411736

D19840.diff
No OneTemporary
Actions

Size

881 B

Referenced Files

None

Subscribers

None

D19840.diff
View Options

	diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
	--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
	+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
	@@ -451,6 +451,11 @@
	// conditions for acceptance. This usually happens after an accepting
	// reviewer resigns or is removed.
	$new_status = DifferentialRevisionStatus::NEEDS_REVIEW;
	+ } else if ($was_revision) {
	+ // This revision was "Needs Revision", but no longer has any rejecting
	+ // reviewers. This usually happens after the last rejecting reviewer
	+ // resigns or is removed. Put the revision back in "Needs Review".
	+ $new_status = DifferentialRevisionStatus::NEEDS_REVIEW;
	}

	if ($new_status === null) {

File Metadata

Mime Type: text/plain
Expires: Wed, Dec 25, 12:10 PM (10 h, 34 s)
Storage Engine: blob
Storage Format: Encrypted (AES-256-CBC)
Storage Handle: 6926168
Default Alt Text: D19840.diff (881 B)

Event Timeline